Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow theme dropdown in onboarding flow #5454

Closed
srirambv opened this issue Jul 30, 2019 · 2 comments
Closed

Allow theme dropdown in onboarding flow #5454

srirambv opened this issue Jul 30, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported

Comments

@srirambv
Copy link
Contributor

Description

As @rossmoody mentioned in #4992 (comment) there should be a dropdown option

Steps to Reproduce

Actual result:

image

Expected result:

Stole @rossmoody image from #4992 (comment)
Welcome Light

In the case of themes the user can see their theme change in real time so that’s the confirmation.
Onboarding flow should also has a dark mode( #3911) which can be a good indication of how it looks when dark mode is enabled.

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @rossmoody @rebron

@kjozwiak
Copy link
Member

kjozwiak commented Jul 30, 2019

Isn't this already implemented in nightly via brave/brave-core#2909? Checked the the latest nightly and see the following using 0.70.18 Chromium: 76.0.3809.72:

Screen Shot 2019-07-30 at 1 44 11 PM

@srirambv am I missing something?

@srirambv
Copy link
Contributor Author

#4992 didn't have the actual implementation which is why i logged this issue. I had not checked the PR which had the new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants