Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement statistical voting for auto-contribute #4475

Closed
evq opened this issue May 17, 2019 · 1 comment · Fixed by brave/brave-core#2630
Closed

Re-implement statistical voting for auto-contribute #4475

evq opened this issue May 17, 2019 · 1 comment · Fixed by brave/brave-core#2630
Assignees
@emerick
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@evq
Copy link
Member

evq commented May 17, 2019 •
edited by NejcZdovc
Loading

Description

The statistical voting from the original javascript implementation is missing from the logic currently used for auto-contribute.

Old implementation: https://github.com/brave-intl/bat-publisher/blob/master/index.js#L419-L433
@NejcZdovc NejcZdovc added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label May 17, 2019
@emerick emerick mentioned this issue Jun 6, 2019
Merged
29 tasks
@emerick emerick added the QA/Yes label Jun 6, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 6, 2019
This was referenced Aug 2, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 5, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Implement statistical voting for auto-contribute brave/brave-core
6 participants
@emerick @evq @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya