Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] HTTPS-Only is broken in 1.73 #42542

Closed
1 of 5 tasks
stoletheminerals opened this issue Nov 27, 2024 · 1 comment · Fixed by brave/brave-core#26781
Closed
1 of 5 tasks

[iOS] HTTPS-Only is broken in 1.73 #42542

stoletheminerals opened this issue Nov 27, 2024 · 1 comment · Fixed by brave/brave-core#26781
Assignees
Labels
http-nowhere Issues when "Upgrade connections to HTTPS" and "Always use secure connections" are enabled OS/iOS Fixes related to iOS browser functionality privacy/https-upgrades Issues related to HTTPS Upgrades feature QA/Test-All-Platforms QA/Yes regression release-notes/exclude

Comments

@stoletheminerals
Copy link

stoletheminerals commented Nov 27, 2024

Description

Brave doesn't let you connect to non-https websites if "Upgrade connections to HTTPS" is set to Standard or Strict mode.

Steps to reproduce

  1. Set "Upgrade connections to HTTPS" to Standard
  2. Open http://www.alwayshttp.com/
  3. Set "Upgrade connections to HTTPS" to Strict
  4. Open http://www.alwayshttp.com/

Actual result

http://www.alwayshttp.com/ will never load

Expected result

In Standard mode http://www.alwayshttp.com/ should load
In Strict mode an interstitial should appear

Reproduces how often

Easily reproduced

Brave version

Beta 1.74
Nightly 1.75
Testflight Release 1.73

Device/iOS version

iPhone 14 Pro / iOS 18.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

App Store Release works correctly, also works correctly with "Upgrade connections to HTTPS" disabled

@stoletheminerals stoletheminerals added http-nowhere Issues when "Upgrade connections to HTTPS" and "Always use secure connections" are enabled OS/iOS Fixes related to iOS browser functionality privacy/https-upgrades Issues related to HTTPS Upgrades feature regression labels Nov 27, 2024
@StephenHeaps StephenHeaps self-assigned this Nov 27, 2024
@stoletheminerals stoletheminerals changed the title [iOS] HTTPS-Only is broken in Nightly and Beta [iOS] HTTPS-Only is broken in 1.73 Nov 27, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 28, 2024
@kjozwiak
Copy link
Member

The above requires 1.73.95 or higher for 1.73.x verification 👍 As per brave/brave-core#26781 (review), loading alwayshttp.com takes a while which is expected. Also double checked with @stoletheminerals & @kylehickinson via Slack. Can use the STR/Cases from brave/brave-core#26781 (comment) as a template for 1.73.x verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http-nowhere Issues when "Upgrade connections to HTTPS" and "Always use secure connections" are enabled OS/iOS Fixes related to iOS browser functionality privacy/https-upgrades Issues related to HTTPS Upgrades feature QA/Test-All-Platforms QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants