Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave iOS crashes if Leo/Leo settings are accessed while Leo is disabled in flags #42150

Closed
2 of 5 tasks
LegalizeNukes opened this issue Nov 7, 2024 · 3 comments · Fixed by brave/brave-core#26484
Closed
2 of 5 tasks

Comments

@LegalizeNukes
Copy link

Description

In Brave iOS v1.70.133 if Leo is disabled using flags (#brave-ai-chat) upon interacting with anything related to Leo (icon, Leo settings) the browser will crash. Either interacting with Leo should do nothing or anything Leo-related should be hidden from the interface.

Steps to reproduce

  1. Disable Leo via flags.
  2. Interact with anything related to Leo in the browser.

Actual result

Browser crashes.

Expected result

Browser should not crash.

Reproduces how often

Easily reproduced

Brave version

1.70.133 Chromium: 129.0.6668.100 (Official Build) stable (64-bit)

Device/iOS version

iPhone 16 Pro on iOS 18.1

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.73.90 or higher for 1.73.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 18, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.0 using version 1.73 (91)

  • Ensured that disabling brave-ai-chat will remove Leo elements from UI and menus.
  • Ensured that Ask Leo is not shown in search bar when enter query.
  • Ensured crash does not occur when using Leo.
example example example example example
Image Image Image Image Image

@Uni-verse
Copy link
Contributor

Verified on iPad (9th Gen) running iOS 17.7.1 using version 1.73 (91)

  • Ensured that disabling brave-ai-chat will remove Leo elements from UI and menus.
  • Ensured that Ask Leo is not shown in search bar when enter query.
  • Ensured crash does not occur when using Leo.
example example example example
Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants