Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http scheme is shown in the URL bar when visiting insecure sites #42070

Closed
3 of 5 tasks
kylehickinson opened this issue Nov 4, 2024 · 2 comments · Fixed by brave/brave-core#26360
Closed
3 of 5 tasks

http scheme is shown in the URL bar when visiting insecure sites #42070

kylehickinson opened this issue Nov 4, 2024 · 2 comments · Fixed by brave/brave-core#26360
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes regression release-notes/include security
Milestone
1.73.x - Release #3

Comments

@kylehickinson
Copy link
Collaborator

Description

The http:// prefix is showing in the URL bar incorrectly when you're browsing an insecure/http site

Image

Regressed in brave/brave-core#26107

Steps to reproduce

  1. Visit http.badssl.com

Actual result

Shows http://

Expected result

Shouldn't show http://

Reproduces how often

Easily reproduced

Brave version

1.70+

Device/iOS version

n/a

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@kylehickinson kylehickinson added OS/iOS Fixes related to iOS browser functionality QA/Yes regression labels Nov 4, 2024
@Brandon-T Brandon-T self-assigned this Nov 4, 2024
@Brandon-T Brandon-T mentioned this issue Nov 4, 2024
Merged
24 tasks
@jamesmudgett
Copy link

@stoletheminerals needs review

@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 28, 2024
This was referenced Nov 28, 2024
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Nov 29, 2024
Open
18 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 29, 2024 •
edited
Loading

The above requires 1.73.95 or higher for 1.73.x verification 👍 @hffvld @Uni-verse please use https://github.com/brave/internal/issues/1228 for verification similar to brave/brave-core#26360 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes regression release-notes/include security
Projects
None yet
Milestone
1.73.x - Release #3
Development

Successfully merging a pull request may close this issue.

[iOS] - Fix URL-Bar LTR-RTL Clipping brave/brave-core
5 participants
@jamesmudgett @kylehickinson @Brandon-T @kjozwiak @brave-builds