Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Open with Tor button style #41546

Closed
aguscruiz opened this issue Oct 10, 2024 · 6 comments · Fixed by brave/brave-core#25927
Closed

Update Open with Tor button style #41546

aguscruiz opened this issue Oct 10, 2024 · 6 comments · Fixed by brave/brave-core#25927
Assignees
@boocmp
Labels
design A design change, especially one which needs input from the design team feature/tor misc/icons OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.73.x - Release

Comments

@aguscruiz
Copy link

We're going to change the style of the "Open with Tor" button in the omnibar.

The idea is to make it look exactly like the other buttons like reader mode, playlist, etc. Remove the background and use our default icon color for omnibar items.

Image

https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=1386-11575&t=ZMxbI58Lb6Hv0sjp-1
@aguscruiz aguscruiz added design A design change, especially one which needs input from the design team OS/Desktop labels Oct 10, 2024
@rebron rebron assigned boocmp and unassigned rebron Oct 10, 2024
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include labels Oct 10, 2024
@rebron rebron moved this to In progress in Front End Oct 10, 2024
@boocmp boocmp mentioned this issue Oct 10, 2024
Merged
24 tasks
@boocmp
Copy link

boocmp commented Oct 11, 2024

There is the .onion button in the Tor window:
Image

Do we want to change the style for it as well?
This is how it will look
Image

@aguscruiz
Copy link
Author

I think the one in the Tor window is fine as it is, since it's what you would want to see highlighted anyways. Let's keep that one with that pink background.

@rebron rebron changed the title Omnibar - Open with Tor button style update urlbar - Open with Tor button style update Oct 12, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 16, 2024
@rebron rebron moved this from In progress to Completed in Front End Oct 16, 2024
@brave-builds brave-builds mentioned this issue Oct 20, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.72.85 or higher for 1.72.x verification 👍

@rebron rebron changed the title urlbar - Open with Tor button style update Update Open with Tor button style Oct 22, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 28, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.72.87 Chromium: 130.0.6723.70 (Official Build) beta (64-bit)
-- | --
Revision | d7efa3dbae2fa83142b51cea45f023f01d3eeb33
OS | Windows 11 Version 23H2 (Build 22631.4391)
  1. Installed 1.72.87
  2. launched Brave
  3. opened nytime.com in a normal window
  4. opened brave.com in a normal window
  5. opened proton.me in a normal window

Confirmed Open in Tor button is updated and matched to the screenshot in the issue

Confirmed when hovered on Open in Tor button, the .onion link is shown

Confirmed when clicked on the Open in Tor button, it navigated to Tor window

nytimes.com brave.com proton.me
Image Image Image
Image Image Image

Dark theme

nytimes.com brave.com proton.me
Image Image Image

Tor window

Confirmed .onion button is shown as expected.

proton.mel nytimes.com
Image Image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 1, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (arm64)
-- | --
Revision | 69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS | macOS Version 14.6.1 (Build 23G93)
  1. Installed 1.72.93
  2. launched Brave
  3. opened nytimes.com in a normal window
  4. opened brave.com in a normal window
  5. opened proton.me in a normal window

Confirmed Open in Tor button is updated and matched to the screenshot in the issue

Confirmed when hovered on Open in Tor button, the .onion link is shown

Confirmed when clicked on the Open in Tor button, it navigated to Tor window

nytimes.com brave.com proton.me
Image Image Image
Image Image Image

Dark theme

nytimes.com brave.com proton.me
Image Image Image

Tor window

Confirmed .onion button is shown as expected.

proton.me nytimes.com
Image Image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave	1.72.95 Chromium: 131.0.6778.24 (Official Build) beta (64-bit) 
Revision	006619fbaf6013cb3495b90fc3885eda343087e5
OS	Linux
JavaScript	V8 13.1.201.5
  1. Installed 1.72.95
  2. launched Brave
  3. opened nytimes.com in a normal window
  4. opened brave.com in a normal window
  5. opened proton.me in a normal window

Confirmed Open in Tor button is updated and matched to the screenshot in the issue

Confirmed when hovered on Open in Tor button, the .onion link is shown

Confirmed when clicked on the Open in Tor button, it navigated to Tor window

Dark theme

nytimes.com brave.com proton.me
Image !Image Image
Image Image Image

Light theme

nytimes.com brave.com proton.me
Image Image Image

Tor window

nytimes.com brave.com proton.me
Image Image Image

@LaurenWags LaurenWags mentioned this issue Nov 11, 2024
Closed
@rebron rebron removed this from Front End Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boocmp boocmp

Labels
design A design change, especially one which needs input from the design team feature/tor misc/icons OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

Updated Tor button style. brave/brave-core
6 participants
@kjozwiak @rebron @aguscruiz @brave-builds @boocmp @MadhaviSeelam