Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Copy URL feature should work when copying from the URL bar #41302

Closed
4 of 5 tasks
pes10k opened this issue Sep 30, 2024 · 4 comments · Fixed by brave/brave-core#25747
Closed
4 of 5 tasks

Clean Copy URL feature should work when copying from the URL bar #41302

pes10k opened this issue Sep 30, 2024 · 4 comments · Fixed by brave/brave-core#25747

Comments

@pes10k
Copy link
Contributor

pes10k commented Sep 30, 2024

Description

Currently iOS only presents users the clean copy option in the “hamburger menu” (…). If you copy the URL from the URL bar, there’s no option

Steps to reproduce

  1. Select the URL in the URL bar
  2. Long press to get the copy etc options
  3. See no “clean copy” option

Actual result

image

Expected result

To have a “clean copy the url” option

Reproduces how often

Easily reproduced

Brave version

Current

Device/iOS version

NA

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

Two suggestions

  • always show the option when selecting all text in the URL bar
  • Always include the clean copy option when the selected text looks like a URL
@kylehickinson
Copy link
Collaborator

Discussed in triage, OK with using "Copy Clean Link" as the copy and letting it slide to second page if necessary, can fix later if needed

@pes10k
Copy link
Contributor Author

pes10k commented Oct 4, 2024

Thanks @kylehickinson thats fantastic!

@hffvld
Copy link
Contributor

hffvld commented Nov 5, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.73 (88)
BraveCore: 1.73.88 (131.0.6778.39)

STEPS:

  1. Launch Brave
  2. Open URL in the new tab, for example, https://www.amazon.com/EF-ECOFLOW-Portable-Charging-Generator/dp/B0B9XB57XM?pd_rd_w=VjwfT&content-id=amzn1.sym.a8f3032b-cf6b-4fad-8ec8-8ede405b4845&pf_rd_p=a8f3032b-cf6b-4fad-8ec8-8ede405b4845&pf_rd_r=0MP1N1518KZJP4JTS3WK&pd_rd_wg=Jp2ky&pd_rd_r=6507e6df-f817-4e9b-899a-06ea1a25739c&pd_rd_i=B0B9XB57XM&ref_=pd_hp_mw_btf_unk_B0B9XB57XM
  3. Tap URL bar > Tap again to open the menu
  4. Tap > > Verify, Copy Clean Link is shown
  5. Tap Copy Clean Link > Open any note-taking app
  6. Paste > Verify, copy clean link works

ACTUAL RESULTS:


1 2
1 2

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 13, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 13, 2024

Verified on iPad Mini (6th gen) using version(s):

Device/OS: iPad Mini (6th gen) / iPadOS 18.0.1
Brave build: 1.73 (89)
BraveCore: 1.73.89 (131.0.6778.69)

STEPS:

  1. Launch Brave
  2. Open URL in the new tab, for example, https://www.amazon.com/EF-ECOFLOW-Portable-Charging-Generator/dp/B0B9XB57XM?pd_rd_w=VjwfT&content-id=amzn1.sym.a8f3032b-cf6b-4fad-8ec8-8ede405b4845&pf_rd_p=a8f3032b-cf6b-4fad-8ec8-8ede405b4845&pf_rd_r=0MP1N1518KZJP4JTS3WK&pd_rd_wg=Jp2ky&pd_rd_r=6507e6df-f817-4e9b-899a-06ea1a25739c&pd_rd_i=B0B9XB57XM&ref_=pd_hp_mw_btf_unk_B0B9XB57XM
  3. Tap URL bar > Tap again to open the menu > Verify, Copy Clean Link is shown
  4. Tap Copy Clean Link > Open any note-taking app
  5. Paste > Verify, copy clean link works

ACTUAL RESULTS:


1 2
1 2

@hffvld hffvld added QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment