Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist Items can't be deleted if the underlying offline cache is cleaned up incorrectly #41252

Closed
3 of 5 tasks
kylehickinson opened this issue Sep 25, 2024 · 1 comment · Fixed by brave/brave-core#25715
Closed
3 of 5 tasks
Assignees
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include

Comments

@kylehickinson
Copy link
Collaborator

Description

Old playlist items that may have had their underlying caches cleaned up by migration logic or other measures not directly died with Playlist cannot be deleted

Steps to reproduce

In Simulator, not easily testable on device:

  1. Add an item to playlist and have it download offline cache
  2. In Finder access the Library/Application Support/Playlist folder and delete the underlying video file that was saved offline
  3. Attempt to delete the item in Playlist

Actual result

It doesn't delete

Expected result

It should delete

Reproduces how often

Easily reproduced

Brave version

Tested 1.69.2, but likely a problem for many versions

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kylehickinson kylehickinson added the OS/iOS Fixes related to iOS browser functionality label Sep 25, 2024
@kylehickinson kylehickinson changed the title Playlist Items can't be deleted if the underlying offline cache is cleaned up Playlist Items can't be deleted if the underlying offline cache is cleaned up incorrectly Sep 25, 2024
@kylehickinson kylehickinson self-assigned this Sep 25, 2024
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Sep 25, 2024
@kylehickinson
Copy link
Collaborator Author

Marking QA/No as there's no good way to reproduce without altering the file system which is not accessible on devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants