Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AdGuard option installs mv3 instead of mv2 #41173

Closed
2 of 6 tasks
kodiakhub opened this issue Sep 20, 2024 · 3 comments · Fixed by brave/brave-core#25798
Closed
2 of 6 tasks

Enable AdGuard option installs mv3 instead of mv2 #41173

kodiakhub opened this issue Sep 20, 2024 · 3 comments · Fixed by brave/brave-core#25798

Comments

@kodiakhub
Copy link

kodiakhub commented Sep 20, 2024

Description

AdGuard released a new update yesterday and replaced the AdGuard extension 4.4.22 (mv2) version. See:

Steps to reproduce

  1. Go to brave://settings/extensions/v2
  2. Enable AdGuard
  3. Check AdGuard extension

Actual result

AdGuard extension (mv3) installed

Expected result

AdGuard extension (mv2) installed

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.117 Chromium: 129.0.6668.59 (Official Build) (64-bit)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@antonok-edm
Copy link
Collaborator

@kodiakhub hi, thanks for your report. We've been in touch with the AdGuard team about this too, they are rolling out a migration for users on their original Mv2 extension ID to their Mv3 version, but will continue hosting an Mv2 version under a different extension's ID (previously designated as their "Beta" extension). We should have this fixed shortly!

@LaurenWags
Copy link
Member

Requires 1.70.126 or higher for verification 👍🏻

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 9, 2024

Verification PASSED on

Brave | 1.70.126 Chromium: 129.0.6668.100 (Official Build) (64-bit)
-- | --
Revision | 35f34f21e597f5f30e9e206b0354cc137df1f2a3
OS | Windows 10 Version 22H2 (Build 19045.4894)
Clean profile_PASSED
Example Example Example Example
Image Image Image Image
Upgrade Profile - PASSED
  1. Install a version prior to this fix (I used 1.70.123)
  2. Close/relaunch to pull griffin
  3. Navigate to brave://settings/extensions/v2
  4. Toggled on "Enable AdGuard™"
  5. See that AdGuard MV2 is not installed - it is the MV3 version:
Example Example Example Example
Image Image Image Image
  1. Update Brave to 1.70.126
    Image

  2. Close/relaunch as needed

  3. Confirm that AdGuard Blocker remains installed

  4. Confirm that AdGuard Blocker MV2 is not yet installed

  5. Confirm that "Enable AdGuard™" is now toggled OFF

Example Example Example
Image Image Image
  1. Confirm able to toggle on "Enable AdGuard™"
  2. Confirm AdGuard Blocker (the MV3 version) and AdGuard Blocker MV2 are installed side by side
Example Example Example Example
Image Image Image Image
  1. Visited a few known pages with ads
  2. Toggled off shields
  3. Confirmed ads are still blocked by the combination of the two AdGuard extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants