Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeable Shortcut Button #41031

Closed
jamesmudgett opened this issue Sep 12, 2024 · 2 comments · Fixed by brave/brave-core#25557
Closed

Changeable Shortcut Button #41031

jamesmudgett opened this issue Sep 12, 2024 · 2 comments · Fixed by brave/brave-core#25557

Comments

@jamesmudgett
Copy link

jamesmudgett commented Sep 12, 2024

Change "Show Bookmarks Shortcut" to "Show Shortcut Button" with a drill down for: [None, Shred, Bookmarks, Downloads, History, Playlist, Leo, Wallet]

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 12, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.73 (87)

  • Ensured that Shortcut Button setting is shown in Settings menu.
  • Ensured that Shortcut Button is set to Hide Shortcut Button by default.
  • Ensured that selecting any of the options in Shortcut Button settings will enable the feature.
  • Ensured that Shortcut Button is shown in normal and private browsing.
  • Ensured that long-pressing on the Shortcut button in the address bar will display the options list.
  • Ensured that all shortcuts are displaying the appropriate views.
  • Ensured hiding shortcut button from the UI.
  • Ensured Shortcut button works in Top bar and Bottom bar configurations.

encountered: #42246

example example example example example example
Image Image Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 12, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 14, 2024

Verified on iPad (7th Gen) running iOS 17.5.1 using version 1.73 (89)

  • Ensured that Shortcut Button setting is shown in Settings menu.
  • Ensured that Shortcut Button is set to Hide Shortcut Button by default.
  • Ensured that selecting any of the options in Shortcut Button settings will enable the feature.
  • Ensured that Shortcut Button is shown in normal and private browsing.
  • Ensured that long-pressing on the Shortcut button in the address bar will display the options list.
  • Ensured that all shortcuts are displaying the appropriate views.
  • Ensured hiding shortcut button from the UI.
  • Ensured Shortcut button menu is displayed in different orientations on tablet device.

encountered: #42246

example example example example
Image Image Image Image
Image Image Image Image

@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment