Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads should not be scheduled between certain hours on mobile #3938

Closed
tmancey opened this issue Mar 29, 2019 · 2 comments · Fixed by brave/brave-core#2672
Closed

Ads should not be scheduled between certain hours on mobile #3938

tmancey opened this issue Mar 29, 2019 · 2 comments · Fixed by brave/brave-core#2672
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
0.68.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 29, 2019

Ads should not be scheduled between 9 PM and 6 AM local time unless the App is being used actively during those hours, see https://docs.google.com/document/d/1QynlNXswjNfhxGeilooS9TjQsIPkYvgpZH8y9FJdRy4/edit# for further information
@tmancey tmancey changed the title Ads should not be scheduled between 9 PM and 6 AM local time unless the App is being used actively during those hours Ads should not be scheduled between 9 PM and 6 AM local time Mar 29, 2019
@tmancey tmancey changed the title Ads should not be scheduled between 9 PM and 6 AM local time Ads should not be scheduled between certain hours Mar 29, 2019
@tmancey tmancey changed the title Ads should not be scheduled between certain hours Ads should not be scheduled between certain hours on mobile Apr 2, 2019
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 4, 2019
@NejcZdovc NejcZdovc assigned NejcZdovc and tmancey and unassigned NejcZdovc Apr 17, 2019
@tmancey tmancey removed their assignment May 8, 2019
@tmancey tmancey mentioned this issue Jun 12, 2019
Merged
29 tasks
@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 12, 2019
@tmancey tmancey self-assigned this Jun 12, 2019
@GeetaSarvadnya
Copy link

@tmancey Is the behavior applicable only for Mobile?

@tmancey
Copy link
Contributor Author

tmancey commented Jul 31, 2019

This functionality was only for mobile, however 1.2.0 only shows ads in the foreground so this feature has been removed

This was referenced Aug 2, 2019
Closed
Closed
Closed
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Ads should not be scheduled between certain hours on mobile brave/brave-core
6 participants
@jsecretan @tmancey @kjozwiak @NejcZdovc @LaurenWags @GeetaSarvadnya