Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New set default screen to UK users #38380

Closed
timchilds opened this issue May 16, 2024 · 9 comments · Fixed by brave/brave-core#25476
Closed

New set default screen to UK users #38380

timchilds opened this issue May 16, 2024 · 9 comments · Fixed by brave/brave-core#25476
Assignees
Labels
enhancement onboarding Front-end related to helping a new user learn about features within the browser. OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude

Comments

@timchilds
Copy link

timchilds commented May 16, 2024

Description:

We have a new set default screen as part of the new onboarding. We also have the Brave.IOS.IsLikelyDefault P3A.

Let's use these in combination.

Requirements

From brave/brave-ios#8674:

(1) Special case: If the user has just installed the app within the past 7 days, instead of recording No, record Not enough info to avoid skewing data
(2) If a user opens a http/https link with Brave immediately record Yes even if within 7 day window

The timing to show the set default screen would be next launch after 7 days has passed, if (2) did not happen.

Please roll out to UK users only.

Design

This screen without the pagination dots and change the "Start Browsing" CTA copy to "Not Now"
https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding-(mobile)---Feb%2C-2024?node-id=3625%3A8401&t=nnN8lgCCp4iTyVVe-1

@timchilds timchilds added OS/iOS Fixes related to iOS browser functionality enhancement onboarding Front-end related to helping a new user learn about features within the browser. labels May 16, 2024
@anthonypkeane
Copy link

@timchilds has finalized the info here, can you please add and move the issue to "ready to work" Thanks

@timchilds
Copy link
Author

@kylehickinson @soner-yuksel here's what I was thinking, maybe I am over simplifying?

From brave/brave-ios#8674:

(1) Special case: If the user has just installed the app within the past 7 days, instead of recording No, record Not enough info to avoid skewing data
(2) If a user opens a http/https link with Brave immediately record Yes even if within 7 day window

The timing to show the set default screen would be next launch after 7 days has passed, if (2) did not happen.

Show this screen without the pagination dots and maybe change the "Start Browsing" copy to "Not Now"
https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding-(mobile)---Feb%2C-2024?node-id=3625%3A8401&t=nnN8lgCCp4iTyVVe-1

@soner-yuksel soner-yuksel changed the title [iOS] Show new set default screen using Brave.IOS.IsLikelyDefault logic Show new set default screen using Brave.IOS.IsLikelyDefault logic Aug 9, 2024
@timchilds timchilds changed the title Show new set default screen using Brave.IOS.IsLikelyDefault logic New set default screen to UK users Aug 28, 2024
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Sep 13, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Nov 13, 2024

@GeetaSarvadnya mind taking a look at this one re: the P3A portion of the verification? If you run into any issues/need help with iOS please reach out to @Uni-verse or @hffvld 👍

@timchilds @DJAndries could we get some more info re: Brave.IOS.IsLikelyDefault as there isn't really any STR/Cases other than the Figma document. @GeetaSarvadnya you can probably find some more info brave/brave-ios#8674.

@timchilds
Copy link
Author

@kjozwiak @GeetaSarvadnya are you looking for the logic that triggers showing the new set default explainer screen? @kylehickinson probably best placed to help there.

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 15, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 15, 2024

Verification PASSED on iPhone 8 version 16.7.10 running Brave Release 1.73 (90)

Brave.IOS.IsLikelyDefault=0_PASSED
  1. Install Brave 1.73(90)
  2. Set brave as default browser via onboarding slide
  3. Open any http/https site
  4. Open brave://local-state file
  5. Look for the metrics Brave.IOS.IsLikelyDefault
  6. Confirmed that the metrics Brave.IOS.IsLikelyDefault response value is 0 as expected
    Image
Brave.IOS.IsLikelyDefault=1_PASSED
  1. Install Brave 1.73(90)
  2. Set brave as default via onboarding slide
  3. Open http/https site
  4. Open brave://local-state file
  5. Look for the metrics Brave.IOS.IsLikelyDefault
  6. Confirmed that the metrics Brave.IOS.IsLikelyDefault response value is 0 as expected
  7. Close brave and set the system date ahead by 7 days
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.IOS.IsLikelyDefault response value is 1 as expected
    Image
Brave.IOS.IsLikelyDefault=2_PASSED
  1. Install Brave 1.73(90)
  2. Set brave as default via onboarding slide
  3. Open http/https site
  4. Open brave://local-state file
  5. Look for the metrics Brave.IOS.IsLikelyDefault
  6. Confirmed that the metrics Brave.IOS.IsLikelyDefault response value is 0 as expected
  7. Open any external app message and click on link and open it via Brave
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.IOS.IsLikelyDefault response value is 2 as expected
    Image

@GeetaSarvadnya
Copy link

@kylehickinson: Could you review the cases above? if I set brave as default browser via onboarding slide and open any https site in the Brave browser, I am getting the metrics Brave.IOS.IsLikelyDefault response value 0 - Is this expected?

cc: @kjozwiak

@kylehickinson
Copy link
Collaborator

@GeetaSarvadnya sorry can you clarify what you mean by "open any https site in the Brave browser" in this case? Do you mean open a link from outside of Brave (like clicking a link from Mail/Notes)?

If you just mean you're loading a page in the browser itself then 0 is correct

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 19, 2024

@kylehickinson:

"open any https site in the Brave browser" - I clicked on the top tiles on the NTP in case 1 and 2.

Only in case 3, I have opened a site on brave via external app messages by clicking on the link

If you just mean you're loading a page in the browser itself then 0 is correct - Thanks!

@kylehickinson So, all the case looks good?

@kylehickinson
Copy link
Collaborator

@GeetaSarvadnya Yep, they look good!

@GeetaSarvadnya GeetaSarvadnya added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement onboarding Front-end related to helping a new user learn about features within the browser. OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
8 participants