-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New set default screen to UK users #38380
Comments
@timchilds has finalized the info here, can you please add and move the issue to "ready to work" Thanks |
@kylehickinson @soner-yuksel here's what I was thinking, maybe I am over simplifying? From brave/brave-ios#8674:
The timing to show the set default screen would be next launch after 7 days has passed, if (2) did not happen. Show this screen without the pagination dots and maybe change the "Start Browsing" copy to "Not Now" |
@GeetaSarvadnya mind taking a look at this one re: the @timchilds @DJAndries could we get some more info re: |
@kjozwiak @GeetaSarvadnya are you looking for the logic that triggers showing the new set default explainer screen? @kylehickinson probably best placed to help there. |
@kylehickinson: Could you review the cases above? if I set brave as default browser via onboarding slide and open any https site in the Brave browser, I am getting the metrics cc: @kjozwiak |
@GeetaSarvadnya sorry can you clarify what you mean by "open any https site in the Brave browser" in this case? Do you mean open a link from outside of Brave (like clicking a link from Mail/Notes)? If you just mean you're loading a page in the browser itself then 0 is correct |
Only in case 3, I have opened a site on brave via external app messages by clicking on the link
@kylehickinson So, all the case looks good? |
@GeetaSarvadnya Yep, they look good! |
Description:
We have a new set default screen as part of the new onboarding. We also have the Brave.IOS.IsLikelyDefault P3A.
Let's use these in combination.
Requirements
From brave/brave-ios#8674:
The timing to show the set default screen would be next launch after 7 days has passed, if (2) did not happen.
Please roll out to UK users only.
Design
This screen without the pagination dots and change the "Start Browsing" CTA copy to "Not Now"
https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding-(mobile)---Feb%2C-2024?node-id=3625%3A8401&t=nnN8lgCCp4iTyVVe-1
The text was updated successfully, but these errors were encountered: