Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same labels on Shields global settings and panel #3589

Closed
tildelowengrimm opened this issue Mar 5, 2019 · 7 comments · Fixed by brave/brave-core#2149
Closed

Use same labels on Shields global settings and panel #3589

tildelowengrimm opened this issue Mar 5, 2019 · 7 comments · Fixed by brave/brave-core#2149
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Mar 5, 2019

Test plan

See brave/brave-core#2149

Description

Current

image 1

Designs

Settings:
shields settings

Shields panel:
shields panel

@tildelowengrimm tildelowengrimm added feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. feature/global-settings Settings at browser level independent of shields settings labels Mar 5, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 6, 2019
@tildelowengrimm
Copy link
Contributor Author

cc: @karenkliu

@cezaraugusto cezaraugusto self-assigned this Mar 11, 2019
@tildelowengrimm
Copy link
Contributor Author

Text should be as follows:

In Shields Panel

- Cross-site trackers blocked [toggle]
- Connections upgraded to HTTPS [toggle]
- Scripts blocked [toggle]
- [ Cookies blocked / Cross-site cookies blocked / All cookies allowed ]
- [ Device recognition attempts blocked / Cross-site device recognition blocked / All device recognition attempts allowed ]

Change Shields global defaults [outlink]

In Settings

# Shields global defaults

- Block cross-site trackers [toggle]
- Upgrade connections to HTTPS [toggle]
- Block scripts [toggle]
- Cookies [ Block all cookies / Only block cross-site cookies / Allow all cookies ]
- Device recognition [ Block all device recognition attempts / Only block cross-site device recognition attempts / Allow all device recognition attempts ]

@karenkliu
Copy link

Added designs to the issue.

@petemill
Copy link
Member

@tomlowenthal please can we keep the section title for Shields and use a sub-section title for 'Global Defaults' as per brave/brave-core#1909? So that we can have Shields as a top-level menu item and then can have other sub-sections if we need them (social media blocking?).

In your latest wording, it seems to keep the section title as Shields global defaults

In @karenkliu 's mockup (in the Description of this issue) it seems to keep that title but omits the description stating that these are defaults and can be overriden per-site.

This is what I had and intend to merge, before the actual settings items get adjusted:
image

@karenkliu
Copy link

karenkliu commented Apr 11, 2019

How's this:
settings

And we can do either of these options later if we want to add in social media blocking:

shields w social media blocking

@karenkliu
Copy link

Reviewed this with @tomlowenthal; we decided to go with a modified version of option B for the social media stuff. I will attach specs to #4109 .

For this issue, here is the design with Tom's feedback:
shields settings

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2019

Verification passed on

Brave 0.68.104 Chromium: 75.0.3770.100 (Official Build) dev (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux
  • Verified global shields settings has shields info and naming convention as mentioned in test plan
    image
  • Verified Shields has the same naming convention as global shields settings
    image

Verified passed with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-01 at 5 16 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants