-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same labels on Shields global settings and panel #3589
Comments
cc: @karenkliu |
Text should be as follows: In Shields Panel
In Settings
|
Added designs to the issue. |
@tomlowenthal please can we keep the section title for Shields and use a sub-section title for 'Global Defaults' as per brave/brave-core#1909? So that we can have In your latest wording, it seems to keep the section title as In @karenkliu 's mockup (in the Description of this issue) it seems to keep that title but omits the description stating that these are defaults and can be overriden per-site. This is what I had and intend to merge, before the actual settings items get adjusted: |
Reviewed this with @tomlowenthal; we decided to go with a modified version of option B for the social media stuff. I will attach specs to #4109 . |
Verification passed on
Verification passed on
Verified passed with
|
Test plan
See brave/brave-core#2149
Description
Current
Designs
Settings:
Shields panel:
The text was updated successfully, but these errors were encountered: