Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapp radar JSON parsing fails in core #33967

Closed
josheleonard opened this issue Oct 27, 2023 · 1 comment · Fixed by brave/token-lists#93
Closed

Dapp radar JSON parsing fails in core #33967

josheleonard opened this issue Oct 27, 2023 · 1 comment · Fixed by brave/token-lists#93
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop

Comments

@josheleonard
Copy link

Description

Requesting the Top Dapps list returns an empty array due to parsing errors

cc: @nvonpentz
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 27, 2023
@nvonpentz nvonpentz mentioned this issue Nov 2, 2023
Merged
@nvonpentz
Copy link

Closed via brave/token-lists#93

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop
Projects
Web3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we convert binance-smart-chain to binance_smart_chain brave/token-lists
2 participants
@nvonpentz @josheleonard