Warning message not being displayed, when click on Confirm Sync code without any code added

[GeetaSarvadnya]

Description

Follow up of #2845

Warning message not being displayed, when click on Confirm Sync code without any code added.
steps to reproduce the issue is same as 2845

Actual result:

Expected result:

Warning message should be displayed as Invalid sync code. please try again

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Brave	0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Windows 10

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? no

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? na
• Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa @cezaraugusto

[srirambv]

Does console log any errors when this issue reproduces?

[GeetaSarvadnya]

@srirambv #3190 (comment) - I did not get any console error.

I am not able to reproduce the issue on 0.59.35 - Needs to be investigated what is fixed in 0.59.35

[srirambv]

cc: @darkdh @AlexeyBarabash

[einaralex]

I'm dealing with the same issue and I have a valid sync code, no error messages and no messages in the console log.
Version: Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)

[kjozwiak]

I'm dealing with the same issue and I have a valid sync code, no error messages and no messages in the console log.
Version: Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)

@einaralex does restarting the browser help? Or are you running into the above issue every single time, even after a restart?

[einaralex]

@kjozwiak I've tried restarting the browser a couple of times now, tried disabling the shield and even restarted the OS, no changes.

brave://version info

[einaralex]

After messing around a bit it seems to work to do a hard reload (cmd+shift+R) on brave://sync page.

[kjozwiak]

Awesome, thanks for the info @einaralex. At least there's a work around for now until we get this fixed. Appreciate your time/input 👍

[GeetaSarvadnya]

Unable to reproduce the issue on 0.63.48 and 0.64.60. Looks like the issue is fixed.

[smorgisborg1]

Managed to bypass issue by first syncing android phone and then adding a new device through the brave://sync menu that loads after a successful sync.

[cezaraugusto]

^^^ cc @AlexeyBarabash @darkdh @SergeyZhukovsky this seems related to the library itself

[AlexeyBarabash]

Here is a PR which should fix brave/brave-core#3038 .

[93RS]

The same problem arises. The click on the button does nothing, whether there are written words, or those words are right or wrong.
Brave: 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
OS: Windows 10 OS Version 1903 (Build 18362.267)

[AlexeyBarabash]

Hopefully this is fixed with brave/brave-core#3038 soon will be available in Nightly builds.

[AlexeyBarabash]

I can verify the fix works on own-built master (0.70.30), but the fix somehow does not work on Nightly (0.70.22).

[AlexeyBarabash]

I can verify fix works on Nightly (0.70.34).

@GeetaSarvadnya @kjozwiak @srirambv @rebron - should the fix for this issue be uplifted to beta/dev/stable?

[kjozwiak]

I can verify the fix works on own-built master (0.70.30), but the fix somehow does not work on Nightly (0.70.22).

@AlexeyBarabash looks like 5e293e8 landed right after 0.70.23 [1] which might explain why it didn't work on 0.70.22? I'm a bit hesitant uplifting something that didn't work one 0.70.22 and then worked on 0.70.34.

If 0.70.22 didn't work because it didn't include 5e293e8, the @brave/uplift-approvers team can deliberate regarding an uplift 👍

• [1] https://github.com/brave/brave-core/commits/master?after=7abb49bdb59ccb4e741f6b9f2f90d50f1ed3de9f+69

[AlexeyBarabash]

@kjozwiak
Yes, I also re-checked the commits history, the fix hadn't work in 0.70.22 because it was landed right after 0.70.23.

When I wrote the message about 0.70.22 I hadn't recheck that, and just installed the latest update for Nightly.

So @brave/uplift-approvers could you please discuss the uplift?

[kjozwiak]

@AlexeyBarabash after deliberating with the @brave/uplift-approvers team, we're going to let this ride the trains from Nightly to Release. There's a few +1's from the community but I don't think this is critical enough to warrant an uplift. 0.68.x has ~a week before release so we try to only uplift critical fixes 👍

[MRVDH]

@kjozwiak so does that mean the fix will be in the next release? Because it still doesn't work for me in the latest (current) Release. (it spins for a while after clicking it but after a while it stops and nothing has happened)

[AlexeyBarabash]

@MRVDH this means the fix first will appear in dev, then in beta and then in release. Each step is a version bump and takes ~ 3 weeks https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule.

[LaurenWags]

Verified passed with

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Warning message not being displayed, when click on Confirm Sync code without any code added #3190 (comment)
• Verified error message displayed when no code or invalid code:

* Verified entering a valid sync code added device to sync chain.

Verification passed on

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

• Verified test plan from Warning message not being displayed, when click on Confirm Sync code without any code added #3190 (comment)

• Verified error message displayed when no code or invalid code:
  

• Verified entering a valid sync code added device to sync chain.

Verification passed on

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Warning message not being displayed, when click on Confirm Sync code without any code added #3190 (comment)
• Verified error message displayed when no code or invalid code:

[RobertCsordas]

I am having exactly the same issue with "Version 1.0.1 Chromium: 78.0.3904.108 (Official Build) unknown (64-bit)". It is Manjaro Linux community/brave package. I'm trying to synchronize 2 Linux machines and an Android phone. One Linux machine synced with the phone, but the other won't - it just does nothing when I click the "Confirm Sync Code" button. It does the same thing if I enter an arbitrary code. There are no error messages in the debug console, no error messages in the Linux console, and no network traffic at all when I click the button.

Creating a new chain and cancelling it solved the issue.

[AlexeyBarabash]

@xdever
it looks similar to #6504 which is fixed in 1.3.x, current dev build.

[VidfamneOrigin]

Trying the 'fix' above on my Win10 (lastest upgrades) / Brave Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit), causes Brave to crash/close after hitting the Confirm-key and it going grey to indicate connection to sync-server. Upon restarting it, I get asked to restore latest session.