Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when changing IPFS size #29621

Open
serkonda7 opened this issue Apr 11, 2023 · 1 comment · May be fixed by brave/brave-core#23433
Open

crash when changing IPFS size #29621

serkonda7 opened this issue Apr 11, 2023 · 1 comment · May be fixed by brave/brave-core#23433

Comments

@serkonda7
Copy link

Description

Brave crashes when setting IPFS cache size below one.

Steps to Reproduce

  1. got to settings page and search for ipfs
  2. locate Maximum IPFS cache size (GB)
  3. Enter a value below 1, e.g. 0.5
  4. click out of the input field and observe crash

Actual result:

Browser crashes

Expected result:

  • Either: Provide an error message that the value is not supported
  • Or: do not crash

Reproduces how often:

Always

Brave version (brave://version info)

1.50.114 Chromium: 112.0.5615.49 (Official Build) (64-bit)

Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Linux
JavaScript | V8 11.2.214.9

Version/Channel Information:

I have not tried other channels.

Other Additional Information:

Miscellaneous Information:

@hashmi-waseem
Copy link

Steps to reproduce this crash:

  1. go to brave://settings/web3
  2. Scroll down to IPFS section
  3. Change the 'Method to resolve IPFS resources' to 'Brave local IPFS node'
  4. Scroll down to the option 'Maximum IPFS cache size (GB)' (bottom of IPFS section)
  5. Enter any decimal value (eg. 1.5)
  6. Press enter button on the keyboard
  7. Observe the browser crash

Issue occurs on version: [Version 1.65.126 Chromium: 124.0.6367.118 (Official Build) (64-bit)]

Fix for the issue: hashmi-waseem/brave-core@454d43e

Screenshot (4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants