Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a pinned tab with wheel button doesn't trigger layout #29594

Closed
sangwoo108 opened this issue Apr 10, 2023 · 2 comments · Fixed by brave/brave-core#17975
Closed

Closing a pinned tab with wheel button doesn't trigger layout #29594

sangwoo108 opened this issue Apr 10, 2023 · 2 comments · Fixed by brave/brave-core#17975
Assignees

Comments

@sangwoo108
Copy link

Description

We have empty space when closing a pinned tab with wheel button

Steps to Reproduce

  1. Pin tabs in vertical tabs
  2. Close a pineed tab in the middle of tabs

Actual result:

image

Expected result:

image

Reproduces how often:

Always

Brave version (brave://version info)

Nightly

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A - behind flag
  • Can you reproduce this issue with the beta channel? Yes - flag is enabled by default
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

The above requires 1.51.87 or higher for 1.51.x verification 👍

@stephendonner stephendonner added feature/vertical-tabs QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 12, 2023
@stephendonner
Copy link

stephendonner commented Apr 13, 2023

Verified PASSED using

Brave 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)

Steps:

  1. installed 1.51.87
  2. launched Brave
  3. enabled Use vertical tabs flag in about://flags
  4. clicked Relaunch
  5. loaded a few sites
  6. context-clicked on a tab and chose Use vertical tabs
  7. pinned a bunch of tabs
  8. context-clicked on a middle tab
  9. chose Close
  10. compared results to 1.51.79

Confirmed there's no empty slot in the tab strip after closing any tab(s)

1.51.87

example example example example
image (3) image (4) image (5) image (6)

1.51.79

example example example
image image (1) image (2)

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants