tabClassification is the same for all tabs

[btlechowski]

Steps to Reproduce

1. Run brave with logging
2. Enable rewards and ads
3. In new tab open https://www.interia.pl/ and make sure tabClassification is set
4. In new tab open https://www.booking.com/ and check tabClassification
5. Keep https://www.booking.com/ active till tabClassification changes
6. In new tab open https://techcrunch.com and wait for tabClassification to change

Actual result:

After step 4: All tabs have "tabClassification":["health & fitness","nutrition"]

[12252:1212:0111/164417.206:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T16:44:17Z","tabId":9,"tabType":"click","tabUrl":"https://www.interia.pl/","tabClassification":["health & fitness","nutrition"]}
[12252:1212:0111/164417.208:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-01-11T16:44:17Z","tabId":9}
[12252:1212:0111/164417.209:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T16:44:17Z","tabId":10,"tabType":"click","tabUrl":"https://www.booking.com/","tabClassification":["health & fitness","nutrition"]}

After step 5: All tabs have "tabClassification":["travel","hotels"]

[12252:1212:0111/165829.671:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T16:58:29Z","tabId":10,"tabType":"click","tabUrl":"https://www.booking.com/","tabClassification":["travel","hotels"]}
[12252:1212:0111/165829.680:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-01-11T16:58:29Z","tabId":10}
[12252:1212:0111/165829.683:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T16:58:29Z","tabId":9,"tabType":"click","tabUrl":"https://www.interia.pl/","tabClassification":["travel","hotels"]}

After step 6: All tabs have "tabClassification":["personal finance","investing"]

[12252:1212:0111/170854.790:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T17:08:54Z","tabId":9,"tabType":"click","tabUrl":"https://www.interia.pl/","tabClassification":["personal finance","investing"]}
[12252:1212:0111/170854.790:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-01-11T17:08:54Z","tabId":9}
[12252:1212:0111/170854.791:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T17:08:54Z","tabId":10,"tabType":"click","tabUrl":"https://www.booking.com/","tabClassification":["personal finance","investing"]}
[12252:1212:0111/170854.799:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-01-11T17:08:54Z","tabId":10}
[12252:1212:0111/170854.800:INFO:ads_service_impl.cc(958)] AdsService Event Log: {"data":{"type":"load","stamp":"2019-01-11T17:08:54Z","tabId":17,"tabType":"click","tabUrl":"https://techcrunch.com/?guccounter=1","tabClassification":["personal finance","investing"]}

Expected result:

tabCassification is set individually per tab as name suggests, It is not global.

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.60.11 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 7

cc @jsecretan @brave/legacy_qa

[mrose17]

Fixed by brave-intl/bat-native-ads#106

[srirambv]

@mrose17 is this targeted for 0.61.x ? The linked PR's are not having milestone.