Vertical Tabs Crash

[Comprehensive-Jason]

Description

Brave Nightly crashes as soon as vertical tabs are enabled.

Steps to Reproduce

0. Set DPI to 125% or 175% or 225%
1. Open Brave Nightly
2. Right click on tab and select use vertical tabs

Actual result:

Brave Nightly immediately crashes

Expected result:

Brave should not crash and vertical tabs should work as they have been in previous releases.

Reproduces how often:

Easily reproduced, occurs every time

Brave version (brave://version info)

Brave	1.52.2 Chromium: 112.0.5615.39 (Official Build) nightly (64-bit)
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Windows 11 Version 22H2 (Build 22624.1470)

Version/Channel Information:

• Can you reproduce this issue with the current release?
  No, vertical tabs aren't rolled out yet.
• Can you reproduce this issue with the beta channel?
  N/A, don't use.

---

Update from @sangwoo108 - looks like it happens on Nightly - changed to 125%

• Can you reproduce this issue with the nightly channel?
  Yes, every time.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
  No.
• Does the issue resolve itself when disabling Brave Rewards?
  No.
• Is the issue reproducible on the latest version of Chrome?
  No, vertical tabs aren't available on Chrome.

Miscellaneous Information:

This issue just started occurring 1 day ago.

[rebron]

@Comprehensive-Jason Do you see a report in brave://crashes? Can you send and post the crash id here.

[rebron]

cc: @sangwoo108

[Comprehensive-Jason]

@rebron This is what I got:

Crash from Wednesday, March 29, 2023 at 7:48:17 PM
Status: Upload requested by user
Local Crash Context: e5f62648-4288-4a54-86c5-fa082efbfad3

[Comprehensive-Jason]

Uploaded:

Crash from Wednesday, March 29, 2023 at 7:48:17 PM
Status: Uploaded
Uploaded Crash Report ID: 2daa0000-0385-da09-0000-000000000000
Upload Time: Wednesday, March 29, 2023 at 8:03:28 PM
Local Crash Context: e5f62648-4288-4a54-86c5-fa082efbfad3

[sangwoo108]

Thank you so much for reporting.

Looks like this one

[ 00 ] `anonymous namespace'::BraveVerticalTabStyle::GetPath(TabStyle::PathType,float,bool,PathType::RenderUnits) ( brave_tab_style_views.inc.cc:154 )
[ 01 ] _tailMerge_esent.dll
[ 02 ] _tailMerge_esent.dll
[ 03 ] static void `anonymous namespace'::GM2TabStyle::PaintTabBackground(class gfx::Canvas *, TabActive, class absl::optional<int>, int) ( tab_style_views.cc:823 )
[ 04 ] _tailMerge_esent.dll
[ 05 ] ThemeServiceFactory::GetBrowserContextToUse(content::BrowserContext *) ( theme_service_factory.cc:27 )
[ 06 ] _tailMerge_esent.dll
[ 07 ] malloc ( allocator_shim_override_ucrt_symbols_win.h:71 )
[ 08 ] Profile::IsTor() ( profile.cc:24 )
[ 09 ] profile_metrics::GetBrowserProfileType(base::SupportsUserData const *) ( browser_profile_type.cc:47 )
[ 10 ] `anonymous namespace'::GM2TabStyle::PaintTab(gfx::Canvas *) ( tab_style_views.cc:515 )
[ 11 ] SkCanvas::SkCanvas(SkIRect const &) ( SkCanvas.cpp:474 )
[ 12 ] ui::PaintContext::PaintContext(ui::PaintContext const &,gfx::Vector2d const &) ( paint_context.cc:33 )
[ 13 ] SkCanvas::internalRestore() ( SkCanvas.cpp:1353 )
[ 14 ] `anonymous namespace'::BraveVerticalTabStyle::PaintTab(gfx::Canvas *) ( brave_tab_style_views.inc.cc:171 )
[ 15 ] views::View::Paint(views::PaintInfo const &) ( view.cc:1243 )
[ 16 ] void GlyphTrackingDevice::~GlyphTrackingDevice() ( SkChromeRemoteGlyphCache.cpp:642 )
[ 17 ] _tailMerge_esent.dll
[ 18 ] _tailMerge_esent.dll
[ 19 ] _tailMerge_esent.dll
[ 20 ] _tailMerge_esent.dll

[sangwoo108]

@Comprehensive-Jason , Sorry but I wasn't able to reproduce this bug on my Win10/11. Could you tell me more about your tabs? Do you have pinned tabs or groups? If so, how many are they?

And also I'm wondering if this happens when you have a single new tab.

[Comprehensive-Jason]

I am using a fresh install of Brave Nightly. I previously tried uninstalling it and clearing my browsing data to fix the problem, but the crashing did not stop. Here's a video of the crash behavior:

[sangwoo108]

@simonhong @petemill @fallaciousreasoning , could you help me with this? Honestly, I have no idea about what can cause this in the call stack.

[fallaciousreasoning]

Interesting - I can't reproduce either (not in a new profile, not in my existing Nightly). The stacktrace doesn't look particularly helpful either - do you think it could be hitting the CHECK_EQ here and just not giving us some useful output?

I did encounter a similar (ish) issue a while back on Linux, where the browser would crash when creating a new window with vertical tabs enabled but it seems different enough that it could be unrelated.

@Comprehensive-Jason do you mind trying the even more drastic step of (temporarily) deleting your Nightly profile?

1. Open brave://version/ and find your Profile Path
   
2. Close Nightly
3. Rename the Brave-Browser-Nightly folder to Brave-Browser-Nightly.bak (mine is in C:\Users\jayha\AppData\Local\BraveSoftware\)
4. Open Nightly and test if it still crashes when you enable vertical tabs

To get back your old profile:

1. Close Nightly
2. Delete the new Brave-Browser-Nightly folder
3. Rename Brave-Browser-Nightly.bak to Brave-Browser-Nightly (or if you want to be extra sure you don't lose it, copy it and then rename).

[sangwoo108]

do you think it could be hitting the CHECK_EQ here and just not giving us some useful output?

Yeah, sounds possible. I'll try adjusting DPI on my machine.

[sangwoo108]

Oh, I adjusted dpi to 175% and it crashed. @Comprehensive-Jason Could you checkout your DPI? I guess it might be okay with 150% or 200%. Meanwhile, I'll try fixing it.

[Comprehensive-Jason]

@fallaciousreasoning I tried your suggestion. The crash still occurs.

@sangwoo108 I changed Windows scale to 300% from my default 125% and clicked on use vertical tabs. The crash no longer occurs!
After changing back to 125%, it now crashes immediately on startup, and I can't open it at all.

[sangwoo108]

300%, thanks! Will chekc that too

[Comprehensive-Jason]

@sangwoo108 After changing back to 125%, it now crashes immediately on startup, and I can't open it at all.

[sangwoo108]

100% might save you to open it, otherwise, I think we should modify pref manually.

[Comprehensive-Jason]

100, 150 percent work. 125,175 percent don't work.

[sangwoo108]

Thanks for checking! Will make a patch asap. Thanks @fallaciousreasoning , That was a huge help!

[kjozwiak]

The above requires 1.51.86 or higher for 1.51.x verification 👍

[stephendonner]

Verification PASSED using

Brave	1.51.86 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS	Windows 10 Version 22H2 (Build 19045.2846)

First, reproduced original crash using 1.52.2:

Steps:

1. on Windows 10, opened the Display control-panel applet
2. chose 175% / 125% (see screenshot, above) for Scale and layout / Custom scaling values
3. launched Brave
4. loaded a few sites
5. context-clicked on the tab's title
6. chose Use vertical tabs

Crashed, in (sample incident ID of 2d380200-cefb-e309-0000-000000000000):

[ 00 ] `anonymous namespace'::BraveVerticalTabStyle::GetPath(TabStyle::PathType,float,bool,PathType::RenderUnits) ( brave_tab_style_views.inc.cc:154 )
[ 01 ] _tailMerge_esent.dll
[ 02 ] _tailMerge_esent.dll
[ 03 ] static void `anonymous namespace'::GM2TabStyle::PaintTabBackground(class gfx::Canvas *, TabActive, class absl::optional<int>, int) ( tab_style_views.cc:823 )
[ 04 ] static void * allocator_shim::internal::PartitionMalloc(const struct allocator_shim::AllocatorDispatch *, unsigned __int64, void *) ( allocator_shim_default_dispatch_to_partition_alloc.cc:302 )
[ 05 ] _tailMerge_esent.dll
[ 06 ] ThemeServiceFactory::GetBrowserContextToUse(content::BrowserContext *) ( theme_service_factory.cc:27 )
[ 07 ] _tailMerge_esent.dll
[ 08 ] _tailMerge_esent.dll
[ 09 ] malloc ( allocator_shim_override_ucrt_symbols_win.h:71 )
[ 10 ] Profile::IsTor() ( profile.cc:24 )
[ 11 ] profile_metrics::GetBrowserProfileType(base::SupportsUserData const *) ( browser_profile_type.cc:47 )
[ 12 ] `anonymous namespace'::GM2TabStyle::PaintTab(gfx::Canvas *) ( tab_style_views.cc:515 )
[ 13 ] _tailMerge_esent.dll
[ 14 ] `anonymous namespace'::BraveVerticalTabStyle::PaintTab(gfx::Canvas *) ( brave_tab_style_views.inc.cc:171 )
[ 15 ] views::View::Paint(views::PaintInfo const &) ( view.cc:1243 )
[ 16 ] void GlyphTrackingDevice::~GlyphTrackingDevice() ( SkChromeRemoteGlyphCache.cpp:642 )
[ 17 ] _tailMerge_esent.dll
[ 18 ] _tailMerge_esent.dll
[ 19 ] _tailMerge_esent.dll
[ 20 ] _tailMerge_esent.dll

example	example	example

Confirmed FIXED using 1.51.86:

Steps:

1. on Windows 10, opened the Display control-panel applet
2. chose 175% / 125% (see screenshot, above) for Scale and layout / Custom scaling values
3. launched Brave
4. loaded a few sites
5. context-clicked on the tab's title
6. chose Use vertical tabs
7. confirmed no crash
8. shut down and relaunched
9. confirmed no crash
10. drag & dropped tabs
11. confirmed no crash

example	example	example	example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.51.86 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Steps:

1. on Windows 11, opened the Display control-panel applet
2. chose 175% / 125% (see screenshot, above) for Scale and layout / Custom scaling values
3. launched Brave
4. loaded a few sites
5. context-clicked on the tab's title
6. chose Use vertical tabs
7. confirmed no crash
8. shut down and relaunched
9. confirmed no crash
10. drag & dropped tabs
11. confirmed no crash

150% (Recommended)

ex	ex	ex

125%

ex	ex	ex

175 %

ex	ex	ex

200%

ex	ex	ex