Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 112.0.5615.39 to Chromium 112.0.5615.49. #29396

Closed
mkarolin opened this issue Mar 29, 2023 · 6 comments · Fixed by brave/brave-core#17831
Closed

Upgrade from Chromium 112.0.5615.39 to Chromium 112.0.5615.49. #29396

mkarolin opened this issue Mar 29, 2023 · 6 comments · Fixed by brave/brave-core#17831
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/112.0.5615.39..112.0.5615.49?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@mkarolin mkarolin assigned emerick and mkarolin and unassigned emerick Mar 29, 2023
This was referenced Mar 29, 2023
Merged
Merged
Merged
@mkarolin mkarolin added the OS/Android Fixes related to Android browser functionality label Mar 29, 2023
@kjozwiak kjozwiak mentioned this issue Mar 30, 2023
Closed
@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C112 on the following platforms:

Platforms that require a spot check due to already completing full check of the affected areas mentioned via #28494 (comment).

Platforms that still need to check/verify the affected areas due to C112 changes as per #28494 (comment).

@Uni-verse believe you mentioned that you checked the affected areas on Tablet but double checking just in case. I do see the affected areas checked off via #29171 (comment) but let me know if that's not the case.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 30, 2023 •
edited
Loading

Verification in progress with

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | macOS Version 12.6.4 (Build 21G526)

Encountered and logged:

Continued testing from #29277 (comment).

Omnibox suggestions entries open correctly - 3 PASSED, 1 FAILED Screen Shot 2023-03-30 at 9 46 39 AM
Case 1: Improve search suggestions toggle is OFF - PASSED 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and ensure that Improve search suggestions toggle is OFF by default
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  5. Confirmed that the search suggestion are same in both Normal and Private window types when the `Improve search suggestions` toggle is OFF
Settings is OFF Normal win suggestions PT suggestions
Screen Shot 2023-03-30 at 9 58 36 AM Screen Shot 2023-03-30 at 9 58 56 AM Screen Shot 2023-03-30 at 9 59 09 AM
Case 2: Improve search suggestions toggle is ON - PASSED 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and and enable the `Improve search suggestions` toggle to ON
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Confirmed that the suggestion entries are more as the toggle is ON
  5. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  6. Confirmed that the search suggestion entries remained same not increased in PT which is expected as the Toggle ON is applicable only for Normal windows search suggestions
Settings is ON Normal win suggestions PT suggestions
Screen Shot 2023-03-30 at 10 00 14 AM Screen Shot 2023-03-30 at 10 00 28 AM Screen Shot 2023-03-30 at 10 00 49 AM
Case 3: Autocomplete searches and URLs, Upgrade case - PASSED 
 1. Clean profile 1.49.132
 2. Go to brave://settings/privacy and toggle the switch `Autocomplete searches and URLs` to ON
 3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
 4. Confirmed that the suggestion entries are more as the toggle is ON
 5. Upgrade the profile to 1.50.x
 6. Go to brave://settings/privacy and ensured that the switch `Autocomplete searches and URLs` is renamed to `Improve search suggestions` 
 7. Confirmed that the toggle is ON as expected
 8. Open new tab and type "test"
 9. Confirmed that the suggestion entries are displayed
Step 2 Step 4 Step 7 Step 9
2 4 7 9
Case 4: Improve search suggestions toggle is ON and SE is not Brave Search (Google) - FAILED, follow up logged 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and and enable the `Improve search suggestions` toggle to ON
  3. Select an SE that is not Brave for both Normal and Private windows, I chose Google
  4. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  5. Confirmed that the suggestion entries are more as the toggle is ON
  6. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  7. Confirmed that the search suggestion entries remained same not increased in PT which is expected as the Toggle ON is applicable only for Normal windows search suggestions - this failed, the suggestions were shown and should not have been. Note, this also reproduces in 1.49.x so it is not a regression but it should still be fixed. Logged https://github.com/brave/brave-browser/issues/29415 for this.
1.49.x 1.50.x
google 1 49 1 google 1 50 1
google 1 49 2 google 1 50 2
Prepopulated search engines look correct - PASSED

  • Confirmed that Prepopulated SE works as expected in Normal/Private/TOR/Guest window types

  • Confirmed that :b ,:sp, :d etc..keywords SE's works as expected

  • Confirmed that selected SE's reatined in brave://settings/search upon browser restart

  • Confirmed that SE's are retained in an upgraded profile

  • Confirmed that prepopulated SE list displays as expected for a region where Brave Search is the default (US):

Example Example Example
Screen Shot 2023-03-30 at 1 02 56 PM Screen Shot 2023-03-30 at 1 03 03 PM Screen Shot 2023-03-30 at 1 03 20 PM
  • Confirmed that prepopulated SE list displays as expected for a region where Google is the default (Finland):
Example Example Example
Screenshot 2023-03-30 at 13 09 57 Screenshot 2023-03-30 at 13 10 04 Screenshot 2023-03-30 at 13 10 15
  • Confirmed that prepopulated SE list displays as expected for a region where Yandex is the default (Russia):
Example Example Example
Screenshot 2023-03-30 at 13 13 29 Screenshot 2023-03-30 at 13 13 36 Screenshot 2023-03-30 at 13 13 53

@stephendonner
Copy link

stephendonner commented Mar 30, 2023 •
edited
Loading

Verification PASSED with

Brave 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Screen Shot 2023-03-30 at 11 36 31 AM

Continued testing from #29277 (comment)

(which used the following build)

Brave 1.50.108 Chromium: 112.0.5615.39 (Official Build) (x86_64)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS macOS Version 11.7.5 (Build 20G1225)
Shields cookies permissions work correctly - PASSED
Case 1: Cookies settings are retained upon browser restart - PASSED 
  1. Clean profile 1.50.110
  2. Open a site A
  3. Tap on the shield and looks for cookies settings
  4. Default cookies settings "Block cross-site cookies" is populated in the dropdown
  5. Change the cookies settings to "Block all cookies" and restart the browser
  6. Ensured that "Block all cookies" cookies settings are retained, restart the browser
  7. Change the cookies settings to "Allow all cookies" and restart the browser
  8. Ensured that "Allow all cookies" cookies settings are retained
example example example
Screen Shot 2023-03-30 at 10 26 54 AM Screen Shot 2023-03-30 at 10 28 03 AM Screen Shot 2023-03-30 at 10 27 49 AM
Case 2: Global cookies settings are retained across all the sites - PASSED 
  1. Clean profile 1.50.110
  2. Open brave://settings/shields and ensure default settings "Block cross-site cookies" is populated in the dropdown
  3. Open a site A, Tap on the shield and ensured default global cookies settings are retained
  4. Open brave://settings/shields, change the cookies settings to "Block all cookies" and restart the browser
  5. Ensured that "Block all cookies" cookies settings are retained
  6. Open brave://settings/shields, change the cookies settings to "Allow all cookies" and restart the browser
  7. Ensured that "Allow all cookies" cookies settings are retained
example example example example example
Screen Shot 2023-03-30 at 10 41 03 AM Screen Shot 2023-03-30 at 10 41 54 AM Screen Shot 2023-03-30 at 10 42 25 AM Screen Shot 2023-03-30 at 10 42 42 AM Screen Shot 2023-03-30 at 10 42 50 AM
Case 3: Cookies settings for a site A are propagated to site A in Private window Tab - PASSED 
    1. Clean profile 1.50.110
    2. Open a site A, tap on the shield and change the default cookies setting to "Allow all cookies"
    3. Open a Private tab window
    4. Open the same site A in the PT and ensure that the "Allow all cookies" settings are retained
    5. Change the cookies settings to "Block all cookies" in the PT 
    6. Open the same site A in the Normal window tab and ensure that the "Block all cookies" settings are NOT retained
example example example example
Screen Shot 2023-03-30 at 10 53 02 AM Screen Shot 2023-03-30 at 10 53 08 AM Screen Shot 2023-03-30 at 10 53 51 AM Screen Shot 2023-03-30 at 10 54 11 AM
Case 4: Cookies settings are retained in an upgraded profile - PASSED 
  1. Clean profile 1.49.x
  2. Open a few sites and change the default site shield settings 
  3. Open brave://settings/shields and change the default global shield settings
  4. Upgrade the profile to 1.50.110
  5. Open the sites and ensured that the site shield settings are reatined
  6. Open brave://settings/shields and ensured that the global shield settings are retained

1.49.132

example example example example example
Screen Shot 2023-03-30 at 11 06 23 AM Screen Shot 2023-03-30 at 11 06 40 AM Screen Shot 2023-03-30 at 11 06 55 AM Screen Shot 2023-03-30 at 11 07 16 AM Screen Shot 2023-03-30 at 11 07 46 AM

1.50.110

example example example example example
Screen Shot 2023-03-30 at 11 12 19 AM Screen Shot 2023-03-30 at 11 12 27 AM Screen Shot 2023-03-30 at 11 12 41 AM Screen Shot 2023-03-30 at 11 12 52 AM Screen Shot 2023-03-30 at 11 13 01 AM
Case 5: cookies settings in brave://settings/cookies works as expected - PASSED 
1. Clean profile 1.50.110
2. Open brave://settings/cookies and select "Block all cookies" settings 
3. Open a site and ensured that the cookies are blocked on the site 
4. Open brave://settings/cookies and select "Allow all cookies" settings
5. Open a site and ensured that the cookies are allowed on the site
example example example example
Screen Shot 2023-03-30 at 11 27 24 AM Screen Shot 2023-03-30 at 11 28 01 AM Screen Shot 2023-03-30 at 11 28 25 AM Screen Shot 2023-03-30 at 11 28 52 AM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 3, 2023 •
edited
Loading

Verification PASSED on

Brave	1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Linux
Omnibox suggestions entries open correctly - 4 PASSED

image

Case 1: Improve search suggestions toggle is OFF - PASSED 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and ensure that Improve search suggestions toggle is OFF by default
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  5. Confirmed that the search suggestion are same in both Normal and Private window types when the `Improve search suggestions` toggle is OFF
Settings is OFF Normal win suggestions PT suggestions
image image image
Case 2: Improve search suggestions toggle is ON - PASSED 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and and enable the `Improve search suggestions` toggle to ON
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Confirmed that the suggestion entries are more as the toggle is ON
  5. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  6. Confirmed that the search suggestion entries remained same not increased in PT which is expected as the Toggle ON is applicable only for Normal windows search suggestions
Settings is ON Normal win suggestions PT suggestions
image image image
Case 3: Autocomplete searches and URLs, Upgrade case - PASSED 
 1. Clean profile 1.49.128
 2. Go to brave://settings/privacy and toggle the switch `Autocomplete searches and URLs` to ON
 3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
 4. Confirmed that the suggestion entries are more as the toggle is ON
 5. Upgrade the profile to 1.50.x
 6. Go to brave://settings/privacy and ensured that the switch `Autocomplete searches and URLs` is renamed to `Improve search suggestions` 
 7. Confirmed that the toggle is ON as expected
 8. Open new tab and type "test"
 9. Confirmed that the suggestion entries are displayed
Step 2 Step 4 Step 7 Step 9
image image image image
Case 4: Improve search suggestions toggle is ON and SE is not Brave Search (Google)_PASSED 
  1. Clean profile 1.50.x
  2. Go to brave://settings/privacy and and enable the `Improve search suggestions` toggle to ON
  3. Select an SE that is not Brave for both Normal and Private windows, I chose Google
  4. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  5. Confirmed that the suggestion entries are more as the toggle is ON
  6. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  7. Confirmed that the search suggestion entries remained same not increased in PT which is expected as the Toggle ON is applicable only for Normal windows search suggestions - this failed, the suggestions were shown and should not have been.
Prepopulated search engines look correct - PASSED
  • Confirmed that Prepopulated SE works as expected in Normal/Private/TOR/Guest window types
  • Confirmed that :b ,:sp, :d etc..keywords SE's works as expected
  • Confirmed that selected SE's reatined in brave://settings/search upon browser restart
  • Confirmed that SE's are retained in an upgraded profile
  • Confirmed that prepopulated SE list displays as expected for a region where Brave Search is the default (IN):
Sharing hub in the omnibox works as expected_PASSED
  • Ensured that sharing hub options in the omnibox works as expected
    image
Info bar colors look correctly_PASSED
  • Confirmed that info bar color looks as expected in light theme
  • Confirmed that info bar color looks as expected in Dark theme
  • Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
Light theme Dark theme
image image
Components (brave://components) update without errors (on new profile)_PASSED
  • No new components are added as part of CR 112
  • Components are updates successfully without any error
    image
Shields cookies permissions work correctly_PASSED
Case 1: Cookies settings are retained upon browser restart_PASSED 
  1. Clean profile 1.51.x
  2. Open a site A
  3. Tap on the shield and looks for cookies settings
  4. Default cookies settings "Block cross-site cookies" is populated in the dropdown
  5. Change the cookies settings to "Block all cookies" and restart the browser
  6. Ensured that "Block all cookies" cookies settings are retained, restart the browser
  7. Change the cookies settings to "Allow all cookies" and restart the browser
  8. Ensured that "Allow all cookies" cookies settings are retained
Case 2: Global cookies settings are retained across all the sites_PASSED 
  1. Clean profile 1.51.x
  2. Open brave://settings/shields and ensure default settings "Block cross-site cookies" is populated in the dropdown
  3. Open a site A, Tap on the shield and ensured default global cookies settings are retained
  4. Open brave://settings/shields, change the cookies settings to "Block all cookies" and restart the browser
  5. Ensured that "Block all cookies" cookies settings are retained
  6. Open brave://settings/shields, change the cookies settings to "Allow all cookies" and restart the browser
  7. Ensured that "Allow all cookies" cookies settings are retained
Case 3: Cookies settings for a site A are propagated to site A in Private window Tab_PASSED 
    1. Clean profile 1.51.x
    2. Open a site A, tap on the shield and change the default cookies setting to "Allow all cookies"
    3. Open a Private tab window
    4. Open the same site A in the PT and ensure that the "Allow all cookies" settings are retained
    5. Change the cookies settings to "Block all cookies" in the PT 
    6. Open the same site A in the Normal window tab and ensure that the "Block all cookies" settings are NOT retained
Case 4: Cookies settings are retained in an upgraded profile_PASSED 
  1. Clean profile 1.49.x
  2. Open a few sites and change the default site shield settings 
  3. Open brave://settings/shields and change the default global shield settings
  4. Upgrade the profile 1.51.x
  5. Open the sites and ensured that the site shield settings are reatined
  6. Open brave://settings/shields and ensured that the global shield settings are retained
Case 5: cookies settings in brave://settings/cookies works as expected_PASSED 
1. Clean profile 1.51.x
2. Open brave://settings/cookies and select "Block all cookies" settings 
3. Open a site and ensured that the cookies are blocked on the site 
4. Open brave://settings/cookies and select "Allow all cookies" settings
5. Open a site and ensured that the cookies are allowed on the site

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2023 •
edited
Loading

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.112 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230305.008.E1
Example Example
Screenshot_20230403-231741 Screenshot_20230403-231736

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.50.112 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TP1A.220624.014
Example Example
Screenshot_20230403_232047_Brave Screenshot_20230403_232111_Brave

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 112.0.5615.39 to Chromium 112.0.5615.49. brave/brave-core
8 participants
@stephendonner @kjozwiak @emerick @LaurenWags @GeetaSarvadnya @mkarolin @brave-builds @MadhaviSeelam