Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop of a vertical tab to a new window results in narrow window size for new window created #28936

Closed
LaurenWags opened this issue Mar 7, 2023 · 1 comment · Fixed by brave/brave-core#17705
Assignees

Comments

@LaurenWags
Copy link
Member

Description

When you drag and drop vertical tab into its own window (creating a new window from the single dropped tab), the resulting window is very narrow, was expecting it to be the same size as original window.

Steps to Reproduce

  1. Have vertical tabs enabled and be using them
  2. Grab a single vertical tab and drag it from original window
  3. Drop elsewhere on the screen to create a new window

Actual result:

Compare original window to newly created window:

Screen Shot 2023-03-07 at 10 20 35 AM

Expected result:

Expected new window to be same size as original window

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.51.12 Chromium: 111.0.5563.50 (Official Build) nightly (x86_64)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron

@stephendonner
Copy link

Verification PASSED using

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Steps:

  1. installed 1.51.79
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-vertical-tabs to Enabled
  5. clicked on Relaunch
  6. context-clicked on the tab's titlebar
  7. clicked on Use Vertical tabs
  8. loaded cnn.com
  9. loaded brave.com
  10. clicked on and dragged the cnn.com tab from the tab strib, into its own window on the desktop
  11. examined the size of the window

Confirmed the resulting window is the same size/dimensions as its parent window/tab (super-imposed/overlaid them, as proof)

step 4 step 7a step 7b step 8
Screen Shot 2023-04-06 at 9 37 29 PM Screen Shot 2023-04-06 at 9 37 43 PM Screen Shot 2023-04-06 at 9 37 48 PM Screen Shot 2023-04-06 at 9 37 57 PM
step 9 step 10 step 11a step 11b
Screen Shot 2023-04-06 at 9 38 12 PM Screen Shot 2023-04-06 at 9 40 59 PM Screen Shot 2023-04-06 at 9 41 36 PM Screen Shot 2023-04-06 at 9 41 56 PM

@rebron rebron changed the title drag and drop of a vertical tab to a new window results in narrow window size for new window created Drag and drop of a vertical tab to a new window results in narrow window size for new window created Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants