Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable brave://flags/#brave-vertical-tabs in Nightly channel #28872

Closed
rebron opened this issue Mar 3, 2023 · 3 comments · Fixed by brave/brave-core#17458 or brave/brave-core#18006
Closed

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 3, 2023

Description

Enable brave://flags/#brave-vertical-tabs as default for Nightly channel

Steps to Reproduce

  1. Go to brave://flags/#brave-vertical-tabs and check that it's selected as Default
  2. Default value should be enabled.
  3. Right click on any tab in horizontal view to see that Vertical tabs option is selected.

Brave version (brave://version info)

1.51.x.

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 3, 2023
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 11, 2023
@stephendonner
Copy link

@rebron @sangwoo108 looks like we need this enabled on beta channel, too, if we're to test it in 1.51.x: https://github.com/brave/brave-core/pull/17458/files

cc @brave/qa-team and setting as QA/Blocked for now

@LaurenWags
Copy link
Member

@stephendonner @rebron we should probably have a separate issue for Beta. Might as well have one for Release too.

@kjozwiak
Copy link
Member

Going to label this as QA/No as the verification on beta will be done via #29658 once brave/brave-core#18065 has been uplifted into 1.51.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment