Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tabs hover-mode pinned tabs should be full-width so tabs are in the same place in minimized-mode #28810

Closed
petemill opened this issue Mar 1, 2023 · 6 comments · Fixed by brave/brave-core#17483

Comments

@petemill
Copy link
Member

petemill commented Mar 1, 2023

Pinned tab in hover-mode would show without tab title. Only the favicon should show, centered.

@sangwoo108
Copy link

the same response from our users: #464 (comment)

@sangwoo108
Copy link

Edge shows title too even tabs are pinned on floating(hover) mode.

image

@petemill , Do you think hiding title is better? cc @aguscruiz (this is what we've talked a long time ago)

@aguscruiz
Copy link

Yeah I think this is the way to go for this, otherwise it becomes jarring if the thing you want to hover on moves around as soon as you do it

@rebron rebron added feature/vertical-tabs priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 3, 2023
@ghost
Copy link

ghost commented Mar 4, 2023

This is Arc way of doing it, having a pinned tab of brave website and above that there are 4 favourites which are now up to 12 we can add there and resizes accordingly.

image

@sangwoo108
Copy link

Hi, @dpthegrey ! Thanks for the suggestion. We are going to plan to make a resizing handle for vertical tab strip. Hopefully that could be similar to what you're expecting.

@stephendonner
Copy link

stephendonner commented Apr 10, 2023

Verification IN-PROGRESS using

Brave 1.51.84 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

Steps:

  1. installed 1.51.84
  2. launched Brave
  3. opened brave://flags
  4. enabled brave://flags/#brave-vertical-tabs flag
  5. clicked Relaunch
  6. loaded a few sites
  7. pinned most of them
  8. context-clicked on a tab and chose Use vertical tabs
  9. loaded a few new sites
  10. clicked on the icon to collapse/hide the panel
  11. (repeated the above, but using 1.50.114)

Confirmed:

  • on hover, side panel auto-expanded to show horizontal, pinned tabs w/titles
  • by default, side panel is collapsed
  • when toggled open, the side panel's pinned-sites favicons are displayed, horizontally
1.51.84 1.50.114
beta-tabs release-tabs
hovered default side panel open
Screenshot 2023-04-10 at 3 31 30 PM Screenshot 2023-04-10 at 3 31 20 PM Screenshot 2023-04-10 at 3 31 34 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants