Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Dark UI modes for brave:// pages. #2822

Open
3 of 5 tasks
Miyayes opened this issue Jan 4, 2019 · 11 comments
Open
3 of 5 tasks

Feature request: Dark UI modes for brave:// pages. #2822

Miyayes opened this issue Jan 4, 2019 · 11 comments

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 4, 2019

Some uses have requested a dark UI modes from brave:// pages, such as brave://rewards or brave:// settings. Currently, the browser's native UI has a dark theme, but the internal brave:// pages are still light and bright.

For example, note the contrast between the color of the dark browser UI and the brave://rewards page and its components.

Pages:

@srirambv srirambv added this to the 1.x Backlog milestone Jan 5, 2019
@cndouglas
Copy link
Contributor

Related: #793

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@cndouglas
Copy link
Contributor

As of 0.65.16 (nightly), most brave:// pages now support dark mode.

Pages still not supported:

@Brave-Matt
Copy link

+1 from reddit:
https://www.reddit.com/r/brave_browser/comments/bxzr16/dark_mode_for_brave_rewards/

@Sa-Ja-Di
Copy link

Also the right mouse context menu should feature the black theme - even Chromium/Chrome is making this now possible.

@bsclifton
Copy link
Member

bsclifton commented Jun 18, 2019

@Sa-Ja-Di with what version of Chrome? Are you using Canary?

I think we'll get that feature for free when we upgrade our Chromium version (guessing Chromium 76 or 77)

@simonhong
Copy link
Member

@Sa-Ja-Di
We already support context menu background theme according to os theme on MacOS(0.65) and Win10(Beta, 0.66). Is this what you're saying?
Screen Shot 2019-06-18 at 11 05 07 AM
Screen Shot 2019-06-18 at 11 04 58 AM

@Sa-Ja-Di
Copy link

More or less, but i meant it in the context of not OS depending - that it is basically possible to have a real full black theme which covers all elements.

@Sa-Ja-Di
Copy link

Sa-Ja-Di commented Jun 18, 2019

@Sa-Ja-Di with what version of Chrome? Are you using Canary?

I think we'll get that feature for free when we upgrade our Chromium version (guessing Chromium 76 or 77)

Is featured in the stable builds of https://chromium.woolyss.com/ works with --force-dark-mode

@bsclifton @simonhong
Edit: That parameter works also with Brave. Context menu now dark within Windows 8

@Brave-Matt
Copy link

+1s from Reddit:
https://www.reddit.com/r/brave_browser/comments/eeum4s/could_we_get_a_option_to_make_braverewards_dark/

Also, @Miyayes -- Wanted to point out that brave://adblock should also be included here.

@Rybec
Copy link

Rybec commented Jul 13, 2022

Sad to see 3 years on this still hasn't gotten to brave://rewards, and for some reason even dark mode addons don't affect it.

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: P5 backlog
Development

No branches or pull requests

9 participants