Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't contact sync servers dialog has unnecessary scrollbar #2814

Closed
btlechowski opened this issue Jan 3, 2019 · 3 comments
Closed

Couldn't contact sync servers dialog has unnecessary scrollbar #2814

btlechowski opened this issue Jan 3, 2019 · 3 comments

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Create a sync chain and ensure you see two devices
  2. Quit Brave
  3. Launch Brave without internet
  4. Check Couldn't contact Sync servers error dialog

Actual result:

The dialog has a vertical scrollbar
image

Expected result:

The dialog does not have a vertical scrollbar

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7
Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

cc @brave/legacy_qa @cezaraugusto

@cezaraugusto
Copy link
Contributor

thanks @GeetaSarvadnya this was fixed by brave/brave-core#1193 and should be available in the next build

@rebron
Copy link
Collaborator

rebron commented Jan 8, 2019

@cezaraugusto Fixed in 59.x? Can you set the milestone if so? Thanks.

@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 14, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jan 14, 2019

Verified passed with

Brave 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified STR from description
    screen shot 2019-01-14 at 5 44 58 pm

Verification passed on

Brave 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

sync_error

Verification PASSED on Ubuntu 18.04 x64 using the following build:

Brave 0.59.24 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

screen shot 2019-01-15 at 11 17 54 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment