We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to unescape special characters in feed titles
1.47.14
brave://flags
brave://flags/#brave-news-v2
Enabled
Relaunch
Customize
Brave News
Turn on Brave News
food
Discover
Food & Wine Magazine
Food & Wine Magazine
100%
cc @mattmcalister @rebron @fallaciousreasoning @petemill @brave/qa-team
The text was updated successfully, but these errors were encountered:
I suspect the original point of escaping was to avoid XSS/HTML injection in feed titles so please make sure the fix for this has sec review
Sorry, something went wrong.
I think this is related to https://github.com/brave/news-aggregator/issues/44
Note: I don't think we need to worry about XSS/HTML injection because the places this is used are either:
This seems to have been fixed a while ago!
No branches or pull requests
Description
Need to unescape special characters in feed titles
Steps to Reproduce
1.47.14
brave://flags
brave://flags/#brave-news-v2
toEnabled
Relaunch
Customize
Brave News
Turn on Brave News
food
in theDiscover
search textfieldFood & Wine Magazine
entryActual result:
Expected result:
Food & Wine Magazine
Reproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @mattmcalister @rebron @fallaciousreasoning @petemill @brave/qa-team
The text was updated successfully, but these errors were encountered: