Follow button text is invisible until hovered over

[stephendonner]

Description

Follow button text is invisible until hovered over

Steps to Reproduce

1. install 1.47.14
2. launch Brave
3. open brave://flags
4. set brave://flags/#brave-news-subscribe-button to Enabled
5. click Relaunch
6. open a new-tab page
7. load planet.mozilla.org
8. click on the Manage Subscriptions News icon in the URL bar
9. look at the resulting UI

Actual result:

Expected result:

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @mattmcalister @fallaciousreasoning @petemill

[fallaciousreasoning]

Wow, that's weird - it doesn't do it on Linux at all. I think it might be macOS specific. I'll have a look

[fallaciousreasoning]

Does this still repro now brave/brave-core#15856 has landed?

[mattmcalister]

Am still seeing the blank follow on MacOS using 1.47.82

[stephendonner]

@fallaciousreasoning Still seeing the issue using

Brave	1.47.91 Chromium: 108.0.5359.48 (Official Build) nightly (x86_64)
Revision	18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS	macOS Version 11.7.1 (Build 20G918)

[mattmcalister]

Same. Also, the icon was updated. Can we get that changed over? cc @martin-c0des

[stephendonner]

Same. Also, the icon was updated. Can we get that changed over? cc @martin-c0des

For cross-reference, that's taken care of now in #26997.

[kjozwiak]

We'll be uplifted the above into the 1.46.x maintenance release via brave/brave-core#16143 once the initial 1.46.x build goes out. Verification will be completed on 1.46.x.

[kjozwiak]

The above requires 1.46.139 or higher for 1.46.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 10 Version 21H2 (Build 19044.2251)

Confirmed initial/default, hover, and click/followed states are rendered correctly

Dark mode:

default	hover	click/followed

Light mode:

default	hover	click/followed

[stephendonner]

Verified PASSED using

Brave	1.46.141 Chromium: 108.0.5359.99 (Official Build) (x86_64)
Revision	410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS	macOS Version 13.1 (Build 22C65)

Dark mode:

default	hover	followed

Light mode:

default	hover	followed

[btlechowski]

Verification PASSED on

Brave	1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
Revision	410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS	Ubuntu 18.04 LTS

Dark mode:

default	hover	followed

Light mode:

default	hover	followed