Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use serial comma in pre-filled Brave News Discover search text #26253

Closed
stephendonner opened this issue Oct 25, 2022 · 6 comments · Fixed by brave/brave-core#15665
Closed

Comments

@stephendonner
Copy link

Description

Should use serial comma in pre-filled Brave NewsDiscover search text.

(Yeah, I know.)

Steps to Reproduce

  1. install 1.47.14
  2. launch Brave
  3. open brave://flags
  4. set brave://flags/#brave-news-v2 to Enabled
  5. click Relaunch
  6. open a new-tab page
  7. click Customize
  8. click Turn on Brave News
  9. beneath the Discover heading, read the pre-filled Search for news, site, topic or RSS feed line

Actual result:

Screen Shot 2022-10-25 at 3 43 16 PM

Expected result:

Search for news, site, topic, or RSS feed

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? `Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @petemill @rmcfadden3

@rmcfadden3
Copy link

+1 on this. Should have the serial comma.

@petemill
Copy link
Member

That's fine, but only if we call it the oxford comma

@stephendonner
Copy link
Author

That's fine, but only if we call it the oxford comma

Not Harvard comma?

@mattmcalister
Copy link

also it doesn't search for news. it should read...

Search for site, topic, or RSS feed

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2022

The above will require 1.46.100 or higher for 1.46.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.100 Chromium: 107.0.5304.91 (Official Build) dev (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. install 1.46.100
  2. launch Brave
  3. open brave://flags
  4. set brave://flags/#brave-news-v2 to Enabled
  5. click Relaunch
  6. open a new-tab page
  7. click Customize
  8. click Turn on Brave News
  9. beneath the Discover heading, read the search-placeholder text

Confirmed it now reads, Search for site, topic, or RSS feed

Screen Shot 2022-11-08 at 9 14 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants