Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Dashboard dialog disappears when clicking Back to Dashboard #26252

Closed
stephendonner opened this issue Oct 25, 2022 · 2 comments
Closed

Comments

@stephendonner
Copy link

stephendonner commented Oct 25, 2022

Description

Customize Dashboard dialog disappears when clicking Back to Dashboard

Found while testing #25563

Steps to Reproduce

  1. install 1.47.14
  2. launch Brave
  3. set brave://flags/#brave-news-v2 to Enabled
  4. click on Relaunch
  5. open a new-tab page
  6. scroll down
  7. click on Show Brave News
  8. click on Customize
  9. click on <-- Back to Dashboard

Actual result:

Customize dialog disappears

Back to Dashboard missing Customize Dashboard dialog
Screen Shot 2022-10-25 at 3 30 50 PM Screen Shot 2022-10-25 at 3 29 12 PM

Expected result:

Should return to the Customize Dashboard dialog

Screen Shot 2022-10-25 at 3 26 09 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/qa-team @rebron @petemill @fallaciousreasoning

@fallaciousreasoning
Copy link

Fixed by brave/brave-core#15755

@fallaciousreasoning
Copy link

One thing I wasn't sure about was whether the 'X' button should close both dialogs. For now it only closes the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants