Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Manager text is not translated in other locales like Hindi #26238

Open
GeetaSarvadnya opened this issue Oct 25, 2022 · 2 comments
Open
Labels

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 25, 2022

Description

Found while testing #26225

Password Manager text is not translated in other locales like Hindi

Steps to Reproduce

  1. Set OS locale to Hindi
  2. Clean profile 1.45.113
  3. Open brave://settings/passwords
  4. Password Manager text is not translated in other locales like Hindi

Actual result:

Password Manager text is not translated in other locales like Hindi

Hindi
image

Expected result:

Password Manager text should be translated in other locales like Hindi

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.45.113 Chromium: 107.0.5304.62 (आधिकारिक बिल्ड) (64-बिट)
पुनरीक्षण 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS Windows 10 Version 21H2 (Build 19044.2130)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

@GeetaSarvadnya GeetaSarvadnya changed the title Password Manager text is not translated in other locales like Germany/Hindi Password Manager text is not translated in other locales like German/Hindi Oct 25, 2022
@mkarolin
Copy link
Contributor

We inherit these translations (or lack of them) from Chromium. For some reason they don't have it translated in Hindi. German does look like it's been translated, though (Passwortmanager).

@GeetaSarvadnya GeetaSarvadnya changed the title Password Manager text is not translated in other locales like German/Hindi Password Manager text is not translated in other locales like Hindi Oct 25, 2022
@kjozwiak kjozwiak added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Oct 25, 2022
@AndyAnds265
Copy link

I know this ticket is old, but this is probably ok - now. I don't see the string in the Transifex resources but for Hindi/German, I don't think that's currently an issue. If this comes up again, I'll submit a ticket to update the string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants