Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as inappropriate behaves as Save in 30-day ads history #26220

Closed
btlechowski opened this issue Oct 24, 2022 · 4 comments · Fixed by brave/brave-core#15655
Closed

Mark as inappropriate behaves as Save in 30-day ads history #26220

btlechowski opened this issue Oct 24, 2022 · 4 comments · Fixed by brave/brave-core#15655

Comments

@btlechowski
Copy link

Similar issue to #26202

Steps to Reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. View an ad
  4. Navigate to brave://rewards
  5. Navigate to 30-day ads history
  6. Click 3 vertical dots
  7. Click Mark as inappropriate

Actual result:

Ad is marked as Saved
image

Expected result:

Ad is marked as inappropriate
image
flag confirmation is sent

[10333:10333:1024/234443.795098:VERBOSE1:redeem_unblinded_token.cc(353)] Successfully redeemed unblinded token flag confirmation for ad_notification with transaction id a97215cb-e75c-4a1d-837c-bd8b1f5b417c and creative instance id 0210de7e-2a7a-4ba7-af73-960acaac63fe

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.47.15 Chromium: 107.0.5304.62 (Official Build) nightly (64-bit)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS Ubuntu 18.04 LTS

cc @jsecretan @tmancey

@tmancey
Copy link
Contributor

tmancey commented Oct 24, 2022

@btlechowski this is working as expected, as "flag" is correct when marking as inappropriate. We send "bookmark" for saved ads. Thanks

@btlechowski
Copy link
Author

This issue is valid. Reopening.

@kjozwiak
Copy link
Member

kjozwiak commented Oct 27, 2022

The above requires 1.45.116 or higher for 1.45.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 28, 2022

Verification PASSED on

Brave | 1.45.116 Chromium: 107.0.5304.91 (Official Build) (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)
  • Reproduced the issue in 1.45.113

  • Verified the STR from the description and ensured that the Ad is marked as inappropriate
    image

  • Confirmed flag confirmation is sent

[24928:12744:1028/153845.002:VERBOSE1:redeem_unblinded_token.cc(349)] Successfully redeemed unblinded token flag confirmation for ad_notification with transaction id b1430661-2a2a-43c8-9fae-fd067b0a3736 and creative instance id 87173187-acb2-432b-a18d-a235f15f1c1c

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 28, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants