Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News: Unfollow button should remove follow and not block content #26090

Closed
petemill opened this issue Oct 18, 2022 · 3 comments · Fixed by brave/brave-core#15499
Closed

News: Unfollow button should remove follow and not block content #26090

petemill opened this issue Oct 18, 2022 · 3 comments · Fixed by brave/brave-core#15499

Comments

@petemill
Copy link
Member

Test Plan

  • Open NTP
  • Scroll down and opt in to brave news
  • Remember the first content's publisher name
  • Click Customize
  • Find the Publisher Name
  • Click Follow
  • -> Publisher should be in the left column
  • Click Unfollow
  • -> Publisher should not be in the left column
  • Close customize
  • Refresh NTP
  • Scroll down to Brave News
  • First content should be the same, i.e. content from the publisher should still be visible
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 20, 2022

@petemill - Follow/Unfollow buttons are behind a flag? and is there a new design?
I am not seeing those buttons in 1.46.70 Chromium: 107.0.5304.36 beta

currently seeing this
image

@stephendonner
Copy link

stephendonner commented Oct 24, 2022

@petemill - Follow/Unfollow buttons are behind a flag? and is there a new design? I am not seeing those buttons in 1.46.70 Chromium: 107.0.5304.36 beta

currently seeing this (snipped image)

@MadhaviSeelam yup, you'll want to set brave://flags/#brave-news-v2 to Enabled.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 25, 2022
@stephendonner
Copy link

stephendonner commented Oct 25, 2022

Verification PASSED using

Brave 1.46.78 Chromium: 107.0.5304.62 (Official Build) beta (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.78
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-news-v2 to Enabled
  5. clicked Relaunch
  6. opened a new-tab page
  7. scrolled down
  8. clicked on Show Brave News
  9. 1st publisher was Daily Mail
  10. clicked Customize
  11. typed daily mail into the Discover search textfield and hit return
  12. clicked on the Follow button/link within the Daily Mail icon
  13. confirmed Daily Mail appeared in the left column, under Following
  14. clicked Unfollow
  15. confirmed Daily Mail was removed from the left column
  16. closed the Customize dialog
  17. clicked on the browser's Reload this page button
  18. scrolled down to Brave News

Confirmed I saw the Daily Mail article in the feed

step 4 step 8 step 9 step 10 step 11 step 13 step 15 step 18
Screen Shot 2022-10-25 at 1 32 52 PM Screen Shot 2022-10-25 at 1 34 25 PM Screen Shot 2022-10-25 at 1 34 30 PM Screen Shot 2022-10-25 at 1 36 44 PM Screen Shot 2022-10-25 at 1 36 39 PM Screen Shot 2022-10-25 at 1 37 37 PM Screen Shot 2022-10-25 at 1 37 43 PM Screen Shot 2022-10-25 at 1 38 26 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment