Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing Scroll for Brave News if brave://flags/#brave-news has been disabled #25278

Closed
kjozwiak opened this issue Sep 8, 2022 · 2 comments
Closed

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 8, 2022

Description

We should remove the Scroll for Brave News string/animation from the NTP if a user has disabled Brave News via brave://flags/#brave-news. Follow up to #25182 which fixes the crash.

Steps to Reproduce

  1. Use the STR/Cases oulined via Fix crash with new tab page when Brave News is disabled via brave://flags brave-core#15025 (comment)
  2. observe that the Scroll for Brave News string/animation is still present/visible even though Brave News was disabled

Actual result:

newsError

Expected result:

We should remove the Scroll for Brave News string/animation once Brave News has been disabled.

Reproduces how often:

100% reproducible using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.45.34 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@mattmcalister
Copy link

This was resolved. Closing.

@myviolinsings
Copy link

How was this issue resolved? I still have the scroll for brave news at the bottom of new page and cannot get rid of it. Flags disabled are: Enable Brave News V2 & Brave News prompts on New Tab Page.
brave flags disabled new tab
brave flags disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants