Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State-level ad targeting setting is not shown #24313

Closed
btlechowski opened this issue Jul 28, 2022 · 3 comments · Fixed by brave/brave-core#14381
Closed

State-level ad targeting setting is not shown #24313

btlechowski opened this issue Jul 28, 2022 · 3 comments · Fixed by brave/brave-core#14381

Comments

@btlechowski
Copy link

Regression introduced in 1.42.x, probably due to #21038

Steps to Reproduce

  1. On Windows: Set Regional format Windows setting to English (United States)
  2. Use US connection (or use charles to override https://geo.ads.brave.com/v1/getstate with {"country":"US","region":"CA"})
  3. Run Brave with logging enabled
  4. Enable rewards and ads
  5. Make sure that response from https://geo.ads.brave.com/v1/getstate has proper country(US) and region
  6. Open Brave Private Ads settings in brave://rewards/
  7. Check if Regional ad relevance is shown

Actual result:

Regional ad relevance is not shown
image

Expected result:

Regional ad relevance is shown
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS Linux
Brave 1.43.51 Chromium: 104.0.5112.57 (Official Build) beta (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @rebron @jsecretan @aseren @brave/qa-team

@LaurenWags
Copy link
Member

Requires 1.42.83 or higher to test 👍🏻

@btlechowski
Copy link
Author

btlechowski commented Jul 29, 2022

Verification passed on

Brave 1.42.83 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS

Verified test plan from the description

locale: US, geo: US-CA

image


Verification passed on

Brave 1.42.83 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

@btlechowski btlechowski added QA Pass-Linux OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality QA Pass-Win64 labels Jul 29, 2022
@btlechowski
Copy link
Author

Verification passed on Brave v1.42.85 on Samsung s7 (Android 8.0).

Verified test plan from the description

Screenshot_20220803-004507_Brave

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants