Cookies being cleared whenever upgrading from C101 -> C102

[kjozwiak]

Description

Cookies are being cleared/removed/lost whenever updating from C101 -> C102. After upgrading, you'll notice that all the websites have been logged out. This is also affecting Chrome and looks like an upstream issue that's being resolved via https://bugs.chromium.org/p/chromium/issues/detail?id=1309921.

@samartnik and myself both reproduced the issue on Chrome. I reproduced it while upgrading from:

• 101.0.4951.61 -> 102.0.5005.58

Downloaded the .apk for 102.0.5005.58 from https://www.apkmirror.com/apk/google-inc/chrome/chrome-102-0-5005-58-release/google-chrome-fast-secure-102-0-5005-58-4-android-apk-download/download/?forcebaseapk=true. Please download/install at your own risk.

Steps to reproduce

1. install ``1.38.119 Chromium: 101.0.4951.67`
2. open a new tab and login into Gmail (restart a few times and ensure you're still logged in)
3. upgrade to any version of Brave that has C102 (listed below the versions that I checked with)
4. notice that you're logged out of Gmail after upgrading

Actual result

Cookies are being removed/lost when upgrading which means users get logged out from every website

Expected result

When users upgrade, they shouldn't be losing cookies which in turn, logs them out from every website.

Issue reproduces how often

100% reproducible when running through the above STR/Cases

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? Yes
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Samsung S10+ (mobile)
• Android version: Android 12

Brave version

• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.109 Chromium 102.0.5005.50 - Reproduced
• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.110 Chromium 102.0.5005.61 - Reproduced
• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.111 Chromium 102.0.5005.61 - Reproduced
• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.112 Chromium 102.0.5005.61 - Reproduced

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? Yes

[kjozwiak]

Closing as this was fixed via #23131 👍

[kjozwiak]

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.39.115 Chromium: 102.0.5005.78 (Official Build) (64-bit)
--- | ---
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Android 12; Build/SP1A.210812.016

Went through the following upgrades using the STR/Cases mentioned below:

• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.115 Chromium 102.0.5005.78
• 1.38.119 Chromium: 101.0.4951.67 -> 1.39.111 Chromium 102.0.5005.61 (re-login) -> 1.39.115 Chromium 102.0.5005.78

Ensured that the following data is being preserved when upgrading:

• Cookies (ensured that websites stay logged in: FB, Twitter, Reddit, Gmail, LinkedIn and other random websites)
• Open Tabs & Tab Groups
• Shield Settings (checked both Global & Per Site
• History
• Passwords (ensured that auto-fill was also working)
• Brave News/Wallet (ensured that they're still enabled/retain all settings)
• Rewards (ensured still enabled and retained all settings including disabling ads/AC)
• Top Tiles & Home Screen shortcuts
• Various Settings (Home/Security/Site Settings/Search Engine etc..)

Also went through #23041 (comment) which checked Sync and a few others areas not mentioned above.

Quick note: If you upgrade from 1.38.119 Chromium: 101.0.4951.67 -> 1.39.115 Chromium 102.0.5005.78, you'll run into the same issue re: the cookies being cleared. However, users would have gone through the following path:

• 1.38.119 Chromium: 101.0.4951.67 - previous release/version
• 1.39.111 Chromium 102.0.5005.61 - would have ran into the following issues (lost cookies) and re-login to websites
• 1.39.115 Chromium 102.0.5005.78 - still logged in/cookies not being removed as expected

---

Verification passed on Samsung Tab A with Android 10 running 1.39.115

• Verified upgrading from 1.38.119 to 1.39.115 retains all sessions and cookies
• Verified session on sites but not on any active tabs are also retained upon upgrade

---

Verification PASSED on Samsung Galaxy Tab A7 running Android 11 using the following build(s):

Brave | 1.39.115 Chromium: 102.0.5005.78 (Official Build) (64-bit)
--- | ---
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Android 11; Build/RP1A.200720.012

Upgraded the GPS version (1.38.119) to 1.39.115 and ensured the upgrade looks good and no data loss after the upgrade

Ensured that the following data is being preserved when upgrading:

• Cookies (ensured that websites stay logged in: FB, Twitter, Reddit, Gmail, LinkedIn and other random websites)
• Open Tabs
• Shield Settings (checked both Global & Per Site
• History
• Passwords (ensured that auto-fill was also working)
• Brave News/Wallet (ensured that they're still enabled/retain all settings)
• Rewards (ensured still enabled and retained all settings including disabling ads/AC)
• Top Tiles & Home Screen shortcuts
• Various Settings (Home/Security/Site Settings/Search Engine etc..)