Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First run dialog buttons should be in the same order as the mockup #22255

Closed
MadhaviSeelam opened this issue Apr 12, 2022 · 1 comment
Closed
Assignees
Labels
closed/by-author onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows

Comments

@MadhaviSeelam
Copy link

Description

First run dialog buttons should display same order as the mockup

Steps to Reproduce

  1. Clean install
  2. Launch Brave
  3. First run dialog Ready for the best privacy online? should be displayed
  4. Verify the dialog matches to the mockup

Actual result:

The order is reversed in 1.37.113 and dialog show "Set Brave as default" followed by "Maybe later"

screenshot 1

Expected result:

The order should be Maybe later followed by Set Brave as default

Reproduces how often:

Brave version (brave://version info)

Brave 1.37.113 Chromium: 100.0.4896.88 (Official Build) (64-bit)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS Windows 11 Version 21H2 (Build 22000.593

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam MadhaviSeelam added bug OS/Windows onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Apr 12, 2022
@MadhaviSeelam
Copy link
Author

Closing as order of buttons is correct for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/by-author onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows
Projects
None yet
Development

No branches or pull requests

2 participants