Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss or close button is missing in grants notification in NTP widget #21587

Closed
GeetaSarvadnya opened this issue Mar 10, 2022 · 2 comments
Closed
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes regression rewards-2.0

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 10, 2022

Description

Found while testing #15146

Unable to dismiss the UGP grants notification from NTP widget as there is no x close button in 1.37.x but it exists in 1.36.x. If there is an Ad grant waiting to be claimed, the ad grants notification will not be shown on the NTP widget until UGP grants is claimed

Steps to Reproduce

  1. Clean profile 1.37.x staging env
  2. Enable rewards
  3. Open an NTP
  4. Dismiss or close button is missing in grants notification in NTP widget

Actual result:

Dismiss or close button is missing in grants notification in NTP widget
image

Expected result:

Dismiss or close button should be present in the grants notification in NTP widget

1.36.x
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.87 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 10 Version 21H2 (Build 19044.1586)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @Miyayes @zenparsing @LaurenWags

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 10, 2022
@zenparsing zenparsing added priority/P4 Planned work. We expect to get to it "soon". design A design change, especially one which needs input from the design team and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 16, 2022
@zenparsing
Copy link

One solution might be to prioritize Ad grants over UGP grants in this display.

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 16, 2022

Given that:

  1. There is a workaround (you can get around this in other parts of the UI, such as Rewards settings page, and perhaps Rewards panel)

  2. It would be better to avoid more design resources on UI/UX handling of this and adding an x

We should just:

One solution might be to prioritize Ad grants over UGP grants in this display.

Seems like a simple, clean solution.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes regression rewards-2.0
Projects
None yet
Development

No branches or pull requests

3 participants