Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News - "velocity" (when scrolling up) stops when top is reached #21475

Closed
bsclifton opened this issue Mar 4, 2022 · 2 comments · Fixed by brave/brave-core#12865
Closed
Assignees
Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 4, 2022

Description

For me, as I'm using it on Beta for example... it seems just fine. There is a behavior which maybe he is referring to...
If you scroll back up after you're done with news, usually it's always having a velocity. When it gets to the top of news, it stops bascially. This might be what he is reporting

clifton 11 hours ago
then you have to try and swipe back up to get back to the regular NTP that you expect (instead of the "velocity" of moving up just naturally taking you to the top of NTP)

Steps to reproduce

  1. Fresh profile
  2. Use a build with News enabled (ex: Beta, 1.37.80)
  3. Open a new tab
  4. You can see News poking up from the top of NTP
  5. Scroll down, opt-in to Brave News
  6. When feed is showing, go ahead and scroll down. You'll notice the swipe creates a velocity or momentum as it scrolls down.
  7. Scroll back up and try to reach the top of the NTP

Actual result

The velocity immediately stops when it gets near the top. It takes three full swipes to get back to where you can see the stats / bookmarks / widget

For reference- where it stops first time:

When you do another big swipe up (swipe 2), this is as far as it gets:

When you try a 3rd time, it finally gets there

Expected result

The velocity shouldn't have stopped; it should keep naturally scrolling and get to the top (where screenshot 3 shows)

Issue reproduces how often

100%

@kjozwiak
Copy link
Member

Above will require 1.38.105 or higher for 1.38.x verification.

@Uni-verse
Copy link
Contributor

Verified using 1.38.105, Chromium 101.0.4951.41

Devices:
Samsung GS21 | Android 12
Samsung Tab S7 | Android 12

Acceptance Criteria

  • Scrolling velocity/performance when scrolling back to top is constant and will stop at top of homepage.
  • Scrolling down from beginning of the news feed was consistent and did not snag.
  • Scrolling through news feed was smooth.
  • Able to scroll through feed in landscape on mobile and tablet devices.
  • Scroll velocity is reduced over time and will eventually stop.
  • News feed will fetch new data as user scrolls down without delay.

Issues noted: Scrolling from the top of the new tab page will stop when news feed begins - brave/brave-core#12865 (comment)

scrolling.mp4
scrolling2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants