Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprint unlock option while restoring wallet #20807

Closed
Pavneet-Sing opened this issue Jan 31, 2022 · 7 comments · Fixed by brave/brave-core#17875
Closed

Add fingerprint unlock option while restoring wallet #20807

Pavneet-Sing opened this issue Jan 31, 2022 · 7 comments · Fixed by brave/brave-core#17875
Assignees
Labels
bug design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jan 31, 2022

Description

Unable to use fingerprint unlock (Biometric authentication) when the wallet is reset then restored. It is an effect of clear fingerprint after wallet reset implementation.

Steps to reproduce

  1. Setup wallet
  2. Reset wallet from settings
  3. Restore wallet, lock it and notice, there is no option to unlock via fingerprint

Actual result

No way to unlock wallet after reset

Expected result

Allow user to add biomatric authentication on wallet restoration screen

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? not yet, but will after 12076 PR

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): phone
  • Android version: Pie and above

Brave version

1.37.9

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

It is an effect of clear fingerprint after wallet reset implementation.

Additional

Need a change in the restore wallet design or flow to enable biomatric authentication unlock.

cc: @jamesmudgett @SergeyZhukovsky

@Pavneet-Sing Pavneet-Sing added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 31, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 7, 2022
@bbondy bbondy added this to Web3 Mar 16, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 16, 2022
@Pavneet-Sing Pavneet-Sing removed their assignment Aug 2, 2022
@Pavneet-Sing Pavneet-Sing added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Aug 2, 2022
@phil-mason
Copy link

@Pavneet-Sing is anyone working on it or is there an ETA?
For me, it is annoying since before the restore, I was used to it.

@Pavneet-Sing
Copy link
Author

Pavneet-Sing commented Feb 24, 2023

@phil-mason It is not in progress and sorry for the inconvenience. We will escalate to add this in the upcoming release. Thanks for reporting.

@Brave-Matt
Copy link

+1
image

@phil-mason
Copy link

@Pavneet-Sing
Great, thank you very much for the information :)

@kjozwiak
Copy link
Member

The above requires 1.50.117 or higher for 1.50.x verification 👍

@Pavneet-Sing
Copy link
Author

Update: Using fingerprint to unlock wallet during reset wallet will available soon in the upcoming release brave/brave-core#17875 & brave/brave-core#17911
cc: @phil-mason @Brave-Matt

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.50.120 x64 build

  • Verified restoring an account via seed phrase prompts to enable Biometric unlock
  • Verified enabling fingerprint unlock works on restoring wallet
  • Verified on a restored account in older version, upgrade to 1.52.15 doesn't prompt for fingerprint unlock
  • Verified restoring wallet with an already created wallet with fingerprint prompts to enable Biometric unlock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants