Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint setting for wallet is not removed when reset #20444

Closed
srirambv opened this issue Jan 11, 2022 · 1 comment · Fixed by brave/brave-core#12076
Closed

Fingerprint setting for wallet is not removed when reset #20444

srirambv opened this issue Jan 11, 2022 · 1 comment · Fixed by brave/brave-core#12076
Assignees
@Pavneet-Sing
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Fingerprint setting for wallet is not removed when reset

Steps to reproduce

  1. Create a wallet and enable fingerprint when prompted
  2. Reset Wallet
  3. Restore a wallet on the same install
  4. Lock wallet, fingerprint prompt is shown for unlocking which wasn't set when restored

Actual result

Fingerprint setting for wallet is not removed when reset

Expected result

Clear all wallet related settings when wallet is reset

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

Found issue on 1.35.79 but happens on channels

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky
@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 11, 2022
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 19, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 25, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 31, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing added this to the 1.37.x - Nightly milestone Feb 2, 2022
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 12 running 1.37.89 x64 Beta build

  • Verified steps from issue description
  • Verified resetting wallet with fingerprint and restoring a new one doesn't retain the fingerprint setting

@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@kjozwiak kjozwiak mentioned this issue Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): clear fingerprint after wallet reset brave/brave-core
3 participants
@anthonypkeane @Pavneet-Sing @srirambv