Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL doesn't get debounced #20368

Closed
ShivanKaul opened this issue Jan 6, 2022 · 4 comments
Closed

URL doesn't get debounced #20368

ShivanKaul opened this issue Jan 6, 2022 · 4 comments

Comments

@ShivanKaul
Copy link
Collaborator

Description

I was trying to use https://github.com/brave/adblock-lists/blob/master/brave-lists/debounce.json to come up with a URL that should get debounced but haven't had much luck.

Steps to Reproduce

  1. Make sure Enable debouncing flag is Enabled in brave:flags
  2. Enter https://m.facebook.com/1.php?u=https://brave.com into omnibox

Actual result:

image

Expected result:

I would expect to be navigated to https://brave.com because of the debounce rule in https://github.com/brave/adblock-lists/blob/master/brave-lists/debounce.json

Reproduces how often:

Always

Brave version (brave://version info)

Stable

Brave 1.33.106 Chromium: 96.0.4664.110 (Official Build) (x86_64)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS macOS Version 11.6 (Build 20G165)

Component version: Brave Local Data Updater - Version: 1.0.45

Version/Channel Information:

Seems to happen on all channels.

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Didn't try
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fmarier and I ran into this, but it seems to work for @pes10k
fyi @pilgrim-brave

@ShivanKaul ShivanKaul added OS/Desktop feature/shields The overall Shields feature in Brave. labels Jan 6, 2022
@stephendonner
Copy link

I get the same on

Brave 1.36.20 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 10 Version 20H2 (Build 19042.1415)

same

@ryanbr
Copy link

ryanbr commented Apr 12, 2022

brave/adblock-lists#821 should help, facebook "1.php" wasn't used, "L.php" is used.

Does https://l.facebook.com/l.php?u=https%3A%2F%2Fbrave.com%2F work @ShivanKaul ?

@ryanbr
Copy link

ryanbr commented Apr 12, 2022

https://www.facebook.com/flx/warn/?u=https%3A%2F%2Fbrave.com%2F&h=AT1f7gds5J3gEdFo8IuBJnJN-cpF1F2Yupv4j_klJX7y7EXeI4d-I7GCLpRdt09wy4NKa9D6Y1PyVJiXqETdaQ3N0_f6Uq4OOzcrYssu5oVTug_slhogn64 still pushed by facebook.

@fmarier fmarier added the privacy/debounce URL debouncer label May 19, 2022
@fmarier
Copy link
Member

fmarier commented Jul 4, 2022

I believe this is resolved now that we have the test URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants