Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't dismiss grant notification #2004

Closed
emerick opened this issue Nov 6, 2018 · 1 comment · Fixed by brave/brave-core#812
Closed

Can't dismiss grant notification #2004

emerick opened this issue Nov 6, 2018 · 1 comment · Fixed by brave/brave-core#812

Comments

@emerick
Copy link
Contributor

emerick commented Nov 6, 2018

Description

It's possible to get into a state where a user is unable to dismiss a grant notification. This is most likely due to an old installation leaving an invalid value in Preferences.

Steps to Reproduce

  1. Delete your existing profile
  2. Launch Brave
  3. Opt-in to Rewards
  4. Close Brave without dismissing the grant notification
  5. In your profile directory, open the Preferences file and in the brave.rewards.notifications section set id to 0
  6. Save the Preferences file
  7. Launch Brave
  8. Try to dismiss grant notification by clicking its OK button

Actual result:

Grant notification can't be dismissed

Expected result:

Grant notification is dismissed when you click OK

Reproduces how often:

Always

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 7, 2018

Verification passed on

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Verification passed on

Brave 0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified notifications stacked on 0.55.22 gets dismissed when upgraded to 0.56.10

Verified passed with

Brave 0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified notifications stacked on 0.55.22 gets dismissed when upgraded to 0.56.10
  • Verified STR from description

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave 0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • stacked 20 notifications using 0.55.20, updated to 0.56.10 and ensured that you could dismiss the notifications
  • stacked 20 notifications using 0.55.22, updated to 0.56.10 and ensured that you could dismiss the notifications
  • ensured that you can dismiss "brave":{"rewards":{"notifications":"[{\"args\":[],\"id\":\"0\",\"timestamp\":1541706932,\"type\":2}
  • ensured that you can dismiss "brave":{"rewards":{"notifications":"[{\"args\":[],\"id\":0,\"timestamp\":1541707248,\"type\":2}]"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment