Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of input values (send and swap) #19855

Closed
onyb opened this issue Dec 1, 2021 · 1 comment · Fixed by brave/brave-core#11363
Closed

Improve formatting of input values (send and swap) #19855

onyb opened this issue Dec 1, 2021 · 1 comment · Fixed by brave/brave-core#11363
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@onyb
Copy link
Member

onyb commented Dec 1, 2021

Similar to #19521, but this issue is about what's allowed to be input in text boxes. It should fix the following:

  • Selecting 100% preset should not round the amount. This doesn't need to be the case for other presets.
  • Precision of amounts (in Swap) should be increased.
  • Very small amounts (in Swap) should not be rounded. Ex: 0.00000000000001 is currently rounded to 0.0001.

Note that #19521 is more about how the amount is presented to the user during transaction confirmation, which may not be the actual thing user is signing (as it stands today).
@onyb onyb added the OS/Desktop label Dec 1, 2021
@onyb onyb mentioned this issue Dec 1, 2021
Merged
24 tasks
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 1, 2021
@onyb onyb added this to the 1.35.x - Nightly milestone Dec 2, 2021
This was referenced Dec 2, 2021
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2021

Brave 1.33.99 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from brave/brave-core#11363
  • Verified when 100% asset preset value is selected shows full decimal range
  • Verified when conversion value is in decimals shows the equivalent value for sending token as well
19855-Linux.mp4
19855-Windows.mov
19855-macOS.mov

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 4, 2021
@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): fix rounding issue with 100% preset amount brave/brave-core
4 participants
@bbondy @kjozwiak @onyb @srirambv