Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCHECK in brave://settings due to getAdsData definition #19802

Closed
emerick opened this issue Nov 29, 2021 · 0 comments · Fixed by brave/brave-core#11312
Closed

DCHECK in brave://settings due to getAdsData definition #19802

emerick opened this issue Nov 29, 2021 · 0 comments · Fixed by brave/brave-core#11312
Assignees
@emerick
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.33.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Nov 29, 2021 •
edited
Loading

@goodov noticed that there's a DCHECK when opening brave://settings:

[98904:10884:1129/174909.495:FATAL:api_response_validator.cc(78)] Check failed: false. Error validating response to `braveRewards.getAdsData`: Error at parameter 'adsIsSupported': Invalid type: expected boolean, found object.

He also found that the root cause is an erroneous definition of the callback parameters for getAdsData in brave_rewards.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Fix DCHECK in brave://settings page due to getAdsData definition brave/brave-core
2 participants
@kjozwiak @emerick