Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow deleting the active network on brave://settings/wallet/networks #19678

Closed
spylogsster opened this issue Nov 23, 2021 · 1 comment · Fixed by brave/brave-core#11234
Closed

Don't allow deleting the active network on brave://settings/wallet/networks #19678

spylogsster opened this issue Nov 23, 2021 · 1 comment · Fixed by brave/brave-core#11234
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Nov 23, 2021 •
edited
Loading

Go to brave://settings/wallet/networks
Add custom networks
Set custom network as active in popup
Try to remove it on page
@spylogsster spylogsster mentioned this issue Nov 23, 2021
Merged
24 tasks
@spylogsster spylogsster changed the title it is possible to delete the active network on brave://wallet/networks it is possible to delete the active network on brave://settings/wallet/networks Nov 23, 2021
@spylogsster spylogsster self-assigned this Nov 23, 2021
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 23, 2021
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 23, 2021
@spylogsster spylogsster mentioned this issue Nov 24, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified unable to remove a custom network when it is set as default
  • Verified there is no menu shown next to the custom network when it is set as default
Network.-.Linux.mp4
Network.-.Windows.mov
Network.-.macOS.mov

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 4, 2021
@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
@bbondy bbondy changed the title it is possible to delete the active network on brave://settings/wallet/networks Don't allow deleting the active network on brave://settings/wallet/networks Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Do not allow to remove the active network on brave://settings/wallet/networks brave/brave-core
4 participants
@bbondy @kjozwiak @spylogsster @srirambv