Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click by Confirm/Sign buttons for Trezor transactions closes wallet panel #19490

Closed
spylogsster opened this issue Nov 16, 2021 · 1 comment · Fixed by brave/brave-core#11139
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@spylogsster
Copy link

Description

Fast first-time double click by the buttons to sign or confirm transactions closes wallet panel

Steps to Reproduce

  1. Sign message or Transaction
  2. Do fast double click by the button first time

Actual result:

Popup closed

Expected result:

Transaction/Message signed

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 16, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 16, 2021
@spylogsster spylogsster self-assigned this Nov 17, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 17, 2021
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 19, 2021
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (arm64)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified steps from issue description
  • Verified panel doesn't auto-close unless manually closed

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Linux
  • Verified steps from issue description
  • Verified panel doesn't auto-close unless manually closed

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 11 Version Dev (Build 22509.1000)
  • Verified steps from issue description
  • Verified panel doesn't auto-close unless manually closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants