Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link for IPFS preference settings page is hidden for some window sizes #19221

Closed
jefersonf opened this issue Nov 3, 2021 · 4 comments · Fixed by brave/brave-core#10880
Closed

Comments

@jefersonf
Copy link

jefersonf commented Nov 3, 2021

Description

On the IPFS preferences page I cannot access the settings link that allows me to change my initial configuration. The link seems to be hidden by the footer.

Steps to Reproduce

  1. Make you first access to ipfs://ipfs.io
  2. Resize your window vertically (In my case it was enough to be in maximized mode)
  3. Try clicking on the settings link

Actual result:

Screenshot from 2021-11-03 17-10-54

Expected result:

Be able to access the settings link in any size window.

Reproduces how often:

Brave version (brave://version info)

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes
@stephendonner
Copy link

Mind providing your screen/window resolution, @jefersonf?

@stephendonner
Copy link

Can confirm; thanks for the report! When I resize my window to make Settings visible, it still doesn't turn into a link until I resize the window a bit more). Looks like 144x144px on my machine reproduces the issue for me.

Screen Shot 2021-11-03 at 3 38 45 PM

@jefersonf
Copy link
Author

Mind providing your screen/window resolution, @jefersonf?

My screen resolution is 1294x672.

@stephendonner
Copy link

Verified PASSED using

Brave 1.33.69 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed I could click on the Settings link even when the window size was very small.

example example
Screen Shot 2021-11-08 at 9 21 11 AM Screen Shot 2021-11-08 at 9 21 33 AM

@rebron rebron changed the title Hidden link in IPFS preference settings page Link for IPFS preference settings page is hidden for some window sizes Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment