Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links inside welcome screen should open in another tab #1781

Closed
cezaraugusto opened this issue Oct 22, 2018 · 5 comments · Fixed by brave/brave-core#708
Closed

links inside welcome screen should open in another tab #1781

cezaraugusto opened this issue Oct 22, 2018 · 5 comments · Fixed by brave/brave-core#708

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Oct 22, 2018

Test Cases

  • ensure that chrome://welcome/ is being launched in a brand new profile
  • ensure that Skip welcome tour is working as expected
  • ensure Enable Rewards opens chrome://rewards/ in a new tab
  • ensure Import Now opens chrome://settings/importData in a new tab
  • ensure Preferences opens chrome://settings/ in a new tab
  • ensure Done closes chrome://welcome/ and opens brave://newtab
  • ensured that each dot moves the welcome page to the next stage of the welcome page

Original Reported Issue

🦁

@NejcZdovc
Copy link
Contributor

this is dupe of #1739

@srirambv
Copy link
Contributor

srirambv commented Oct 26, 2018

Verification Passed on

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux
  • Verified all links in welcome screen open in individual new tabs

Verification Passed on

Brave 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified all links in welcome screen open in individual new tabs

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Updated milestone to hotfix2 since this will be included in 0.55.x hotfix2.

@kjozwiak
Copy link
Member

kjozwiak commented Oct 30, 2018

Clearing flags as we'll need to check this with the new RC2 just incase. Should be a quick verification either way.

@btlechowski
Copy link

btlechowski commented Oct 30, 2018

Verification Passed on

Brave 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows 7 x64
  • ensured that chrome://welcome/ is being launched in a brand new profile
  • ensured that Skip welcome tour is working as expected
  • ensured Enable Rewards opens chrome://rewards/ in a new tab
  • ensured Import Now opens chrome://settings/importData in a new tab
  • ensured Preferences opens chrome://settings/ in a new tab
  • ensured Done closes chrome://welcome/ and opens brave://newtab
  • ensured that each dot moves the welcome page to the next stage of the welcome page

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • ensured that chrome://welcome/ is being launched in a brand new profile
  • ensured that Skip welcome tour is working as expected
  • ensured Enable Rewards opens chrome://rewards/ in a new tab
  • ensured Import Now opens chrome://settings/importData in a new tab
  • ensured Preferences opens chrome://settings/ in a new tab
  • ensured Done closes chrome://welcome/ and opens brave://newtab
  • ensured that each dot moves the welcome page to the next stage of the welcome page
Brave 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified that brave://welcome/ is being launched in a brand new profile
  • Verified that Skip welcome tour is working as expected
  • Verified Enable Rewards opens brave://rewards/ in a new tab
  • Verified Import Now opens brave://settings/importData in a new tab
  • Verified Preferences opens brave://settings/ in a new tab
  • Verified Done closes brave://welcome/ and opens brave://newtab
  • Verified that individual welcome page intro can be clicked individually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment