Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme's menu-item hover color is incorrect, in Settings #16802

Closed
stephendonner opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9356
Closed

Dark theme's menu-item hover color is incorrect, in Settings #16802

stephendonner opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9356

Comments

@stephendonner
Copy link

stephendonner commented Jul 7, 2021

Description

Dark theme's menu-item hover color is incorrect, in Settings

Steps to Reproduce

  1. load brave://settings/appearance
  2. choose Dark from Brave colors
  3. hover the mouse pointer over any of the left-hand side category headings
  4. look at the hover color

Actual result:

Screen Shot 2021-07-06 at 5 27 04 PM

Expected result:

It should be 737ADE per

124678855-39143700-de78-11eb-8470-0563e7548c97

See #16111 (comment) and Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=491%3A13498

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

/cc @karenkliu

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. loaded brave://settings/appearance
  2. chose Dark from Brave colors
  3. hovered the mouse pointer over the left-hand side category headings
  4. looked at the hover color

confirmed it's a slightly lighter shade 👍

old new
Screen Shot 2021-07-08 at 10 32 23 AM Screen Shot 2021-07-08 at 10 32 31 AM

Also verified via code inspection: https://github.com/brave/brave-core/blob/447cac3e4cba69397a706e987343bcfe12732a40/browser/resources/settings/brave_overrides/settings_menu.js#L122 - color: #737ADE !important;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants