Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus state causing the UI element to shift #16776

Closed
spylogsster opened this issue Jul 5, 2021 · 1 comment · Fixed by brave/brave-core#9335
Closed

Focus state causing the UI element to shift #16776

spylogsster opened this issue Jul 5, 2021 · 1 comment · Fixed by brave/brave-core#9335

Comments

@spylogsster
Copy link

Description

In #16111 focus state causing the UI element to shift

Steps to Reproduce

  • Open settings and click by any menu item

Actual result:

Expected result:

element is not shifted

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified FIXED using

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/ and clicked on the various feature-area heading under Settings (e.g. IPFS in the screenshots below)
  4. looked at the focus ring and pane heading

Confirmed:

  • hover color is "blurple"
  • clicked-state color is orange
hover clicked
Screen Shot 2021-07-06 at 3 09 45 PM Screen Shot 2021-07-06 at 3 10 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants